1839814 - Move `nsIEditor.wrapWidth` to `nsIEditorMailSupport`

Status: RESOLVED FIXED

(Core :: DOM: Editor, task, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

It's used only by the mail composers, but the value needs to be stored for EditorBase::GetAndInitDocEncoder(). Therefore, we cannot move it into comm-central.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1839814 - Move `nsIEditor.wrapWidth` to `nsIEditorMailSupport` r=m_kato!

It's used only by the mail composers. However, EditorBase::mWrapColumn is
also used by TextEditor. Therefore, EditorBase still needs to manage the
member, but the setters, SetWrapColumn() and SetWrapWidth() can be in
TextEditor and HTMLEditor.

Depends on D181835

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1839814 - QI `nsIEditorMailSupport` when accessing its `wrapWidth` r=mkmelin!

nsIEditor.wrapWidth is moved into nsIEditorMailSupport since it's used only
by the email composers. Therefore, some callers need to QI from nsIEditor.
(FYI: QI is expensive so that doing it in GetCurrentEditor() by default seems
risky for the performance.)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4acda6e7aa2f
QI `nsIEditorMailSupport` when accessing its `wrapWidth` r=mkmelin

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35b70265e584
Move `nsIEditor.wrapWidth` to `nsIEditorMailSupport` r=m_kato

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/35b70265e584