1839843 - Exceptions in Prettier are not correctly shown on treeherder

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Mark Banner (:standard8)]

I noticed that a missing comma caused a syntax error that failed to be reported properly on treeherder, and additionally caused it not to be picked up by the review bot.

https://treeherder.mozilla.org/logviewer?job_id=420254734&repo=try

The output was:

[task 2023-06-22T09:38:38.156Z] An error occurred running prettier. Please check the following error messages:
[task 2023-06-22T09:38:38.156Z] 
[task 2023-06-22T09:38:38.157Z] [error] remote/cdp/JSONHandler.sys.mjs: SyntaxError: Unexpected token, expected "," (10:3)
[task 2023-06-22T09:38:38.157Z] [error]    8 |   Log: "chrome://remote/content/shared/Log.sys.mjs",
[task 2023-06-22T09:38:38.157Z] [error]    9 |   HTTP_404: "chrome://remote/content/server/httpd.sys.mjs"
[task 2023-06-22T09:38:38.157Z] [error] > 10 |   HTTP_405: "chrome://remote/content/server/httpd.sys.mjs",
[task 2023-06-22T09:38:38.157Z] [error]      |   ^
[task 2023-06-22T09:38:38.157Z] [error]   11 |   HTTP_505: "chrome://remote/content/server/httpd.sys.mjs",
[task 2023-06-22T09:38:38.157Z] [error]   12 |   Protocol: "chrome://remote/content/cdp/Protocol.sys.mjs",
[task 2023-06-22T09:38:38.157Z] [error]   13 |   RemoteAgentError: "chrome://remote/content/cdp/Error.sys.mjs",

The problem is that we're not returning this sort of error as an error to the lint harness. Therefore we print out the custom error and report failure, but it doesn't get parsed correctly.

I have a patch to try and fix this. We won't be able to mark it as a specific file, but we should at least be able to get the error reported.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1839843 - Ensure exceptions from Prettier are correctly shown on treeherder and reviewbot. r?#linter-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/451f8e9bcede
Ensure exceptions from Prettier are correctly shown on treeherder and reviewbot. r=linter-reviewers,andi

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/451f8e9bcede