1839916 - Implement Bounce Tracking Protection Core Detection Logic

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, enhancement, P2)

Description

[Paul Zühlcke [:pbz]]

This bug is for implementation of the core bounce tracking protection logic. This includes

• BounceTrackingProtection: A singleton holding the user activation map and bounce tracker map.
• BounceTrackingState: An object attached to each top level CanonicalBrowsingContexts which keeps track of the navigation flow and manages a BounceTrackingRecord.
• BounceTrackingRecord: Used to hold metadata about extended navigations, such as initialHost, finalHost, bounce set, storage access set.

We can add these components under toolkit/components/antitracking/bouncetrackingprotection

Comment 1

[Paul Zühlcke [:pbz]]

Attachment: Bug 1839916 - Add a bounce tracking component under antitracking. r=bvandersloot

Comment 2

[Paul Zühlcke [:pbz]]

Attachment: Bug 1839916 - Update BrowsingContextWebProgress to hold BounceTrackingState objects. r=bvandersloot!,nika!

Depends on D182341

Comment 3

[Paul Zühlcke [:pbz]]

Attachment: Bug 1839916 - Add navigation callbacks for BounceTrackingState in DocumentLoadListener. r=bvandersloot!,smaug!

Depends on D182342

Comment 4

[Paul Zühlcke [:pbz]]

Attachment: Bug 1839916 - Extend ContentBlockingUserInteraction to call BounceTrackingProtection on user interaction. r=bvandersloot!

Depends on D182343

Comment 5

[Paul Zühlcke [:pbz]]

Attachment: Bug 1839916 - Add simple bounce tracking protection tests. r=bvandersloot!

Depends on D182344

Comment 6

[Paul Zühlcke [:pbz]]

For manual testing:

Enable the feature by setting privacy.bounceTrackingProtection.enabled to true. This requires an application restart.

You can observe the state of the two maps via the browser console like so:

 let btProtection = Cc[
    "@mozilla.org/bounce-tracking-protection;1"
  ].getService(Ci.nsIBounceTrackingProtection);

// Hosts of the maps are exposed via
btProtection.bounceTrackerCandidateHosts;
btProtection.userActivationHosts

Logging can be enabled by running with:

MOZ_LOG="BounceTrackingProtection:4"

4 = debug is quite noisy, you can also drop that to 3 = info

https://bounce-tracking-demo.glitch.me/ is a good demo site. After going through the redirect flows btProtection.bounceTrackerCandidateHosts should be populated. Note that you may have to wait 10 seconds (timeout) for the bounce tracking algorithm to kick in.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fce071d0f22b
Add a bounce tracking component under antitracking. r=bvandersloot,anti-tracking-reviewers
https://hg.mozilla.org/integration/autoland/rev/44f32df69c08
Update BrowsingContextWebProgress to hold BounceTrackingState objects. r=bvandersloot,nika
https://hg.mozilla.org/integration/autoland/rev/39cbf84f51b7
Add navigation callbacks for BounceTrackingState in DocumentLoadListener. r=bvandersloot,smaug
https://hg.mozilla.org/integration/autoland/rev/3713d0250e5e
Extend ContentBlockingUserInteraction to call BounceTrackingProtection on user interaction. r=bvandersloot,anti-tracking-reviewers
https://hg.mozilla.org/integration/autoland/rev/062039e3c9ca
Add simple bounce tracking protection tests. r=bvandersloot,anti-tracking-reviewers

Comment 8

[Cristian Tuns]

Backed out for causing build bustages in BounceTrackingRecord.cpp

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/toolkit/components/antitracking/bouncetrackingprotection/BounceTrackingRecord.cpp:54:10: error: local variable 'setStr' will be copied despite being returned by name [-Werror,-Wreturn-std-move]

Comment 9

[Paul Zühlcke [:pbz]]

Huh, that's odd. This built fine locally and static-analysis passed too... Looking.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c459fb2b051
Add a bounce tracking component under antitracking. r=bvandersloot,anti-tracking-reviewers
https://hg.mozilla.org/integration/autoland/rev/aeab1abeef2f
Update BrowsingContextWebProgress to hold BounceTrackingState objects. r=bvandersloot,nika
https://hg.mozilla.org/integration/autoland/rev/815021dbe6fe
Add navigation callbacks for BounceTrackingState in DocumentLoadListener. r=bvandersloot,smaug
https://hg.mozilla.org/integration/autoland/rev/c4068176e8e1
Extend ContentBlockingUserInteraction to call BounceTrackingProtection on user interaction. r=bvandersloot,anti-tracking-reviewers
https://hg.mozilla.org/integration/autoland/rev/97b7c9d34869
Add simple bounce tracking protection tests. r=bvandersloot,anti-tracking-reviewers

Comment 11

[Cristina Horotan [:chorotan]]

Backed out 5 changesets (bug 1839916) for causing build bustage at BounceTrackingState.cpp

Backout: https://hg.mozilla.org/integration/autoland/rev/51cb6e0f07c8a1cb46c92a89d18192f3be61e3c1

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=97b7c9d348698788a9d3ca81dc80b5bdf7776413

Failure log: https://treeherder.mozilla.org/logviewer?job_id=422893691&repo=autoland&lineNumber=72228

Comment 12

[Paul Zühlcke [:pbz]]

Did another 3 try runs that all look green, including all the build targets. 🤞🏻

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30fabd692c21
Add a bounce tracking component under antitracking. r=bvandersloot,anti-tracking-reviewers
https://hg.mozilla.org/integration/autoland/rev/935dc69ac6dd
Update BrowsingContextWebProgress to hold BounceTrackingState objects. r=bvandersloot,nika
https://hg.mozilla.org/integration/autoland/rev/818295cb0381
Add navigation callbacks for BounceTrackingState in DocumentLoadListener. r=bvandersloot,smaug
https://hg.mozilla.org/integration/autoland/rev/7933f0be98d0
Extend ContentBlockingUserInteraction to call BounceTrackingProtection on user interaction. r=bvandersloot,anti-tracking-reviewers
https://hg.mozilla.org/integration/autoland/rev/ff623ceacdca
Add simple bounce tracking protection tests. r=bvandersloot,anti-tracking-reviewers

Comment 14

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/30fabd692c21
https://hg.mozilla.org/mozilla-central/rev/935dc69ac6dd
https://hg.mozilla.org/mozilla-central/rev/818295cb0381
https://hg.mozilla.org/mozilla-central/rev/7933f0be98d0
https://hg.mozilla.org/mozilla-central/rev/ff623ceacdca