1839919 - Persistence of user agent globals in BounceTrackingProtection singleton

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, enhancement, P2)

Description

[Paul Zühlcke [:pbz]]

The bounce tracking map and user activation maps in the BounceTrackingProtection need to be persisted across restarts. This is needed so we can also run purging after a browser restart. While extended navigations don't span across browser sessions, the bounce tracking timer period does.

We can store both of these maps in SQLite tables.
Any entries for Private Browsing need to stay in memory and must not be written to disk. Ideally we would also prune these entries on last-pb-context-exited.

The storage needs a cleaner implementation for nsIClearDataService.

Comment 1

[Paul Zühlcke [:pbz]]

Attachment: Bug 1839919 - Move BounceTrackingProtection user agent globals to dedicated storage class. r=bvandersloot

Comment 2

[Paul Zühlcke [:pbz]]

Attachment: Bug 1839919 - Update BounceTrackingProtection tests for new getter/setter format. r=bvandersloot!

Comment 3

[Paul Zühlcke [:pbz]]

Attachment: Bug 1839919 - Add tests for persistence and OA separation. r=bvandersloot!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1f7b77f841b
Move BounceTrackingProtection user agent globals to dedicated storage class. r=bvandersloot,anti-tracking-reviewers
https://hg.mozilla.org/integration/autoland/rev/325f849a24df
Update BounceTrackingProtection tests for new getter/setter format. r=bvandersloot,anti-tracking-reviewers
https://hg.mozilla.org/integration/autoland/rev/df1f8aa6637f
Add tests for persistence and OA separation. r=bvandersloot,anti-tracking-reviewers

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e535f2555616
Backed out 8 changesets (bug 1839919, bug 1876579, bug 1878915) for causing non-unified build bustages on nsCOMPtr.h.

Comment 6

[Cosmin Sabou [:CosminS]]

Backed out for causing non-unified build bustages on nsCOMPtr.h.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel&fromchange=99ce75dc42c534d659e372ec56b098770129dfb3&tochange=c5246b9e5ee675b2d60c16640c4d6a08e39e983d&selectedTaskRun=SAOmallGTRGGVfIczQvYHg.0

Failure logs:

• non-unified bustages -https://treeherder.mozilla.org/logviewer?job_id=447102035&repo=autoland
• TV failure (likely ending as a tier 1 failure) - https://treeherder.mozilla.org/logviewer?job_id=447101861&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/e535f255561617e36b88c3ca861c1703c65bf549

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/96bf0ee8cb16
Move BounceTrackingProtection user agent globals to dedicated storage class. r=bvandersloot,anti-tracking-reviewers
https://hg.mozilla.org/integration/autoland/rev/c9e0596d156e
Update BounceTrackingProtection tests for new getter/setter format. r=bvandersloot,anti-tracking-reviewers
https://hg.mozilla.org/integration/autoland/rev/b2ba9f681e48
Add tests for persistence and OA separation. r=bvandersloot,anti-tracking-reviewers

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/96bf0ee8cb16
https://hg.mozilla.org/mozilla-central/rev/c9e0596d156e
https://hg.mozilla.org/mozilla-central/rev/b2ba9f681e48