1839920 - Rename GetASCIIOrigin and GetUTFOrigin to GetWHATWGOrigin

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Nika Layzell [:nika] (ni? for response)]

We currently have two different concepts of "origin" which we use in Gecko associated with a nsIPrincipal. One is the origin which is a unique internal string conceptually corresponding 1:1 with a nsIPrincipal's access rights, and the other is the asciiOrigin, which returns the origin string according to the WHATWG URL specificiation. This string is formatted differently, leaves out internal information like containers, and returns the string "null" for more types of URLs.

We should rename GetASCIIOrigin and GetUTFOrigin to make it more clear which origin they correspond to in new code, and to avoid folks using these origins when they want to be using nsIPrincipal::Origin and vice-versa.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1839920 - Rename Get{ASCII,UTF}Origin to GetWebExposedOriginSerialization, r=smaug!

This should make uses of the type more clearly indicating where the
origin came from, and should help avoid potential confusion between this
origin and nsIPrincipal::origin in new code.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd545a8b6f9a
Rename Get{ASCII,UTF}Origin to GetWebExposedOriginSerialization, r=smaug,necko-reviewers,anti-tracking-reviewers,bvandersloot,jesup

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/fd545a8b6f9a