1840096 - Identify duckduckgo in Windows default browser agent/WDBA telemetry

Status: RESOLVED FIXED

(Toolkit :: Default Browser Agent, enhancement, P3)

Description

[Romain Testard [:RT]]

Similarly to what was done on https://bugzilla.mozilla.org/show_bug.cgi?id=1738211 we need to extend the list of identified browsers with the addition of the duckduckgo browser given the Windows launch of their client application.
Looking at the registry they use ApplicationName of "DuckDuckGo"

Comment 1

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

Attachment: AppXtzt71pvwdgv9mm1zrgdqvc10rbjyynrf.reg

Comment 2

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

DDG uses the AppX installer. Relevant part of the registry is attached; key is AppXtzt71pvwdgv9mm1zrgdqvc10rbjyynrf.

Comment 3

[Shridhar Shatrughan]

(In reply to Nick Alexander :nalexander [he/him] from comment #2)

DDG uses the AppX installer. Relevant part of the registry is attached; key is AppXtzt71pvwdgv9mm1zrgdqvc10rbjyynrf.

Hey @nalexander,

In https://searchfox.org/mozilla-central/source/toolkit/mozapps/defaultagent/DefaultBrowser.cpp#132, I notice that the AppX installer key is being used to disambiguate EdgeWithEdgeHTML and EdgeWithBlink.

  for (const auto& [prefix, browser] : kFriendlyNamePrefixes) {
    // Find matching Friendly Name prefix.
    if (!wcsnicmp(friendlyName.data(), prefix.data(), prefix.length())) {
      if (browser == Browser::EdgeWithBlink) {
        // Disambiguate EdgeWithEdgeHTML and EdgeWithBlink.
        // The ProgID below is documented as having not changed while Edge was
        // actively developed. It's assumed but unverified this is true in all
        // cases (e.g. across locales).
        //
        // Note: at time of commit EdgeWithBlink from the Windows Store was a
        // wrapper for Edge Installer instead of a package containing Edge,
        // therefore the Default Browser associating ProgID was not in the form
        // "AppX[hash]" as expected. It is unclear if the EdgeWithEdgeHTML and
        // EdgeWithBlink ProgIDs would differ if the latter is changed into a
        // package containing Edge.
        constexpr std::wstring_view progIdEdgeHtml{
            L"AppXq0fevzme2pys62n3e0fbqa7peapykr8v"};

        if (!wcsnicmp(registeredApp.get(), progIdEdgeHtml.data(),
                      progIdEdgeHtml.length())) {
          return Browser::EdgeWithEdgeHTML;
        }
      }

In the case of DuckDuckGo, I assume there's only one version of the browser we're interested in detecting?
Hence it's not clear to me where I can use this key (AppXtzt71pvwdgv9mm1zrgdqvc10rbjyynrf) .

Comment 4

[Nick Rishel [:nrishel]]

:Shridhar You're correct, there's only one version for DDG that we want to monitor. The Edge disambiguation code is a weird special case to account for Edge having two browsers of the same name.

Comment 5

[Shridhar Shatrughan]

Attachment: Bug 1840096 - Add parameters to identify DuckDuckGo in WDBA Telemetry. r=nalexander

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/845f618bbdf6
Add parameters to identify DuckDuckGo in WDBA Telemetry. r=nalexander

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/845f618bbdf6

Comment 8

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

Comment on attachment 9348293 [details]
Bug 1840096 - Add parameters to identify DuckDuckGo in WDBA Telemetry. r=nalexander

Beta/Release Uplift Approval Request

• User impact if declined: None. The impact to Mozilla is that we have less visibility into the success of the DuckDuckGo Windows browser to attract existing Firefox users.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch is very small: it extends an existing list to match an additional case and reports that case via existing telemetry channels. Romain has verified the telemetry is collected on Beta: https://sql.telemetry.mozilla.org/queries/94875/source.
• String changes made/needed:
• Is Android affected?: No

Comment 9

[Pascal Chevrel:pascalc]

Nick, this patch doesn't graft cleanly to the release branch.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1840096 - Add parameters to identify DuckDuckGo in WDBA Telemetry. r=nalexander

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/e26ce7fb8b23

Comment 12

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-release/rev/e26ce7fb8b23

Comment 13

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

This got merged while I was out. Thanks, all!