1840135 - implement new rust backend for nsIDataStorage

Status: RESOLVED FIXED

(Core :: Security: PSM, enhancement, P1)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler]]

The new backend will address issues like blocking shutdown (bug 1610136) and having insufficient slots for entries (bug 1818984).

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Attachment: Bug 1840135 - introduce rust implementation of nsIDataStorage r?djackson!,nkulatova!

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The following patch is waiting for review from an inactive reviewer:

ID	Title	Author	Reviewer Status
D181904	Bug 1840135 - introduce rust implementation of nsIDataStorage r?djackson!,nkulatova!	keeler	mak: Back Aug 18, 2023

:keeler, could you please find another reviewer?

For more information, please visit BugBot documentation.

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Attachment: request.md

Comment 4

[Chris H-C :chutten]

Comment on attachment 9350035 [details]
request.md

PRELIMINARY NOTES:

(Sorry it took so long to get to this. Usually my SLA is 2 business days, but Montreallhands threw me for a loop.)

Since this data collection is Glean, you might be interested to learn we have ./mach data-review for helping to generate a data collection review request template from the information you entered in the metrics definition. Be sure to check that out for your next data collection.

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Dana Keeler is responsible for the permanent part of the collection.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/568451480af9
introduce rust implementation of nsIDataStorage r=nkulatova,nika,mak

Comment 6

[Norisz Fay [:noriszfay]]

Backed out for causing bustage on DataStorageManager.cpp

Backout link

Push with failures

Failure log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e69a7143b38d
introduce rust implementation of nsIDataStorage r=nkulatova,nika,mak

Comment 8

[Iulian Moraru]

Backed out for causing failures on test_sss_sanitizeOnShutdown.js.

• Push with failures

• Failure log

• Backout link

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/876bd2f18415
introduce rust implementation of nsIDataStorage r=nkulatova,nika,mak

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/876bd2f18415