1840162 - Create "Recommended by Firefox" ad component

Status: VERIFIED FIXED

(Firefox :: Shopping, task, P2)

Description

[Fred Chasen [:fchasen]]

Attachment: recommendation.png

Recommended by Firefox component from the Shopping Recommendations API.
Acts as button to the link returned by the API.

• Title
• Image from CDN
• Reliability rating
• Adjusted rating
• Price

Hidden if the API returns no recommendations.

Figma Link: https://www.figma.com/file/Wu4kaHSfKSQnzkym7qek3R/Shopping-Experience-MVP?type=design&node-id=22-15104&mode=design&t=CLJchjO0Hh1ZY6Ck-4

Accessibility annotations: https://www.figma.com/file/Wu4kaHSfKSQnzkym7qek3R/Shopping-Experience-MVP?type=design&node-id=69-48515&mode=design&t=CLJchjO0Hh1ZY6Ck-4

Comment 1

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1840162 - Create recommended by Firefox ad component. r=#shopping-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32fc79395dfa
Create recommended by Firefox ad component. r=shopping-reviewers,flod,Gijs

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for causing assertion failures and bc fails on browser_adjusted_rating.js

• backout: https://hg.mozilla.org/integration/autoland/rev/788a140a7adf9ed889bae70fb64a269c4edc1dd7
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=32fc79395dfa266f4ecda867e71bb62a9d0a016c
• failure log: https://treeherder.mozilla.org/logviewer?job_id=425407110&repo=autoland&lineNumber=27277

[task 2023-08-09T15:46:12.315Z] 15:46:12     INFO - TEST-START | browser/components/shopping/tests/browser/browser_adjusted_rating.js
[task 2023-08-09T15:46:12.518Z] 15:46:12     INFO - GECKO(17217) | [Child 17411: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 7f8cb1cbec00 == 2 [pid = 17411] [id = 1]
[task 2023-08-09T15:46:12.520Z] 15:46:12     INFO - GECKO(17217) | [Child 17411: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 4 (7f8ccf4c27a0) [pid = 17411] [serial = 4] [outer = 0]
[task 2023-08-09T15:46:12.520Z] 15:46:12     INFO - GECKO(17217) | [Child 17411: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 5 (7f8cb1cbf000) [pid = 17411] [serial = 5] [outer = 7f8ccf4c27a0]
[task 2023-08-09T15:46:12.596Z] 15:46:12     INFO - GECKO(17217) | [Child 17411: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 6 (7f8cb1cbfc00) [pid = 17411] [serial = 6] [outer = 7f8ccf4c27a0]
[task 2023-08-09T15:46:12.739Z] 15:46:12     INFO - GECKO(17217) | Assertion failure: !foundWebScheme || StringBeginsWith(aboutSpec, "about:preferences"_ns) || StringBeginsWith(aboutSpec, "about:addons"_ns) || StringBeginsWith(aboutSpec, "about:newtab"_ns) || StringBeginsWith(aboutSpec, "about:debugging"_ns) || StringBeginsWith(aboutSpec, "about:ion"_ns) || StringBeginsWith(aboutSpec, "about:compat"_ns) || StringBeginsWith(aboutSpec, "about:logins"_ns) || StringBeginsWith(aboutSpec, "about:home"_ns) || StringBeginsWith(aboutSpec, "about:welcome"_ns) || StringBeginsWith(aboutSpec, "about:devtools"_ns) || StringBeginsWith(aboutSpec, "about:pocket-saved"_ns) || StringBeginsWith(aboutSpec, "about:pocket-home"_ns) (about: page must not contain a CSP including a web scheme), at /builds/worker/checkouts/gecko/dom/security/nsContentSecurityUtils.cpp:1338
[task 2023-08-09T15:46:12.740Z] 15:46:12     INFO - GECKO(17217) | #01: nsContentSecurityUtils::AssertAboutPageHasCSP(mozilla::dom::Document*) [dom/security/nsContentSecurityUtils.cpp:1325]
[task 2023-08-09T15:46:12.741Z] 15:46:12     INFO - GECKO(17217) | #02: mozilla::dom::Document::EndLoad() [dom/base/Document.cpp:8188]
[task 2023-08-09T15:46:12.743Z] 15:46:12     INFO - GECKO(17217) | #03: nsHtml5TreeOpExecutor::DidBuildModel(bool) [parser/html/nsHtml5TreeOpExecutor.cpp:225]
[task 2023-08-09T15:46:12.744Z] 15:46:12     INFO - GECKO(17217) | #04: nsHtml5TreeOpExecutor::RunFlushLoop() [parser/html/nsHtml5TreeOpExecutor.cpp:730]
[task 2023-08-09T15:46:12.745Z] 15:46:12     INFO - GECKO(17217) | #05: nsHtml5ExecutorReflusher::Run() [parser/html/nsHtml5TreeOpExecutor.cpp:82]
[task 2023-08-09T15:46:12.746Z] 15:46:12     INFO - GECKO(17217) | #06: mozilla::RunnableTask::Run() [xpcom/threads/TaskController.cpp:560]
[task 2023-08-09T15:46:12.747Z] 15:46:12     INFO - GECKO(17217) | #07: mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) [xpcom/threads/TaskController.cpp:886]
[task 2023-08-09T15:46:12.748Z] 15:46:12     INFO - GECKO(17217) | #08: mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) [xpcom/threads/TaskController.cpp:0]
[task 2023-08-09T15:46:12.749Z] 15:46:12     INFO - GECKO(17217) | #09: mozilla::TaskController::ProcessPendingMTTask(bool) [xpcom/threads/TaskController.cpp:495]
[task 2023-08-09T15:46:12.750Z] 15:46:12     INFO - GECKO(17217) | #10: mozilla::detail::RunnableFunction<mozilla::TaskController::TaskController()::$_0>::Run() [xpcom/threads/nsThreadUtils.h:549]
[task 2023-08-09T15:46:12.751Z] 15:46:12     INFO - GECKO(17217) | #11: nsThread::ProcessNextEvent(bool, bool*) [xpcom/threads/nsThread.cpp:1203]
[task 2023-08-09T15:46:12.752Z] 15:46:12     INFO - GECKO(17217) | #12: NS_ProcessNextEvent(nsIThread*, bool) [xpcom/threads/nsThreadUtils.cpp:480]
[task 2023-08-09T15:46:12.752Z] 15:46:12     INFO - GECKO(17217) | #13: mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) [ipc/glue/MessagePump.cpp:85]
[task 2023-08-09T15:46:12.753Z] 15:46:12     INFO - GECKO(17217) | #14: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:346]
[task 2023-08-09T15:46:12.754Z] 15:46:12     INFO - GECKO(17217) | #15: nsBaseAppShell::Run() [widget/nsBaseAppShell.cpp:150]
[task 2023-08-09T15:46:12.755Z] 15:46:12     INFO - GECKO(17217) | #16: XRE_RunAppShell() [toolkit/xre/nsEmbedFunctions.cpp:717]
[task 2023-08-09T15:46:12.756Z] 15:46:12     INFO - GECKO(17217) | #17: mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*) [ipc/glue/MessagePump.cpp:235]
[task 2023-08-09T15:46:12.758Z] 15:46:12     INFO - GECKO(17217) | #18: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:346]
[task 2023-08-09T15:46:12.758Z] 15:46:12     INFO - GECKO(17217) | #19: XRE_InitChildProcess(int, char**, XREChildData const*) [toolkit/xre/nsEmbedFunctions.cpp:0]
[task 2023-08-09T15:46:12.853Z] 15:46:12     INFO - GECKO(17217) | #20: content_process_main(mozilla::Bootstrap*, int, char**) [ipc/contentproc/plugin-container.cpp:58]
[task 2023-08-09T15:46:12.856Z] 15:46:12     INFO - GECKO(17217) | #21: main [browser/app/nsBrowserApp.cpp:375]
[task 2023-08-09T15:46:12.859Z] 15:46:12     INFO - GECKO(17217) | #22: __libc_start_main [/lib/x86_64-linux-gnu/libc.so.6 + 0x21b97]
[task 2023-08-09T15:46:12.859Z] 15:46:12     INFO - GECKO(17217) | #23: ??? [/builds/worker/workspace/build/application/firefox/firefox-bin + 0x45809]
[task 2023-08-09T15:46:12.860Z] 15:46:12     INFO - GECKO(17217) | #24: ??? (???:???)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c0d18e46c980
Create recommended by Firefox ad component. r=shopping-reviewers,flod,Gijs

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/c0d18e46c980

Comment 6

[Rares Doghi, Desktop QA]

Verified as fixed in our latest 119.0a1 (2023-08-28). Please note that for the time being this is now the "More to consider" card.