1840182 - Crash in [@ mozilla::net::nsHttpHandler::Init]

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P2)

Description

[Andrew McCreight [:mccr8]]

Crash report: https://crash-stats.mozilla.org/report/index/c2a9a029-6c85-45a8-a622-8af550230621

MOZ_CRASH Reason: MOZ_DIAGNOSTIC_ASSERT(false) (Try to init HttpHandler after shutdown)

Top 10 frames of crashing thread:

0  xul.dll  mozilla::net::nsHttpHandler::Init  netwerk/protocol/http/nsHttpHandler.cpp:314
0  xul.dll  mozilla::net::nsHttpHandler::GetInstance  netwerk/protocol/http/nsHttpHandler.cpp:204
1  xul.dll  mozCreateComponent  startupcache/StartupCacheInfo.cpp:49
1  xul.dll  mozilla::xpcom::CreateInstanceImpl  xpcom/components/StaticComponents.cpp:11299
2  xul.dll  mozilla::xpcom::StaticModule::CreateInstance const  xpcom/components/StaticComponents.cpp:13375
2  xul.dll    xpcom/components/nsComponentManager.cpp:184
2  xul.dll  nsComponentManagerImpl::GetServiceLocked  xpcom/components/nsComponentManager.cpp:971
3  xul.dll  nsComponentManagerImpl::GetServiceByContractID  xpcom/components/nsComponentManager.cpp:1160
3  xul.dll  CallGetService  xpcom/components/nsComponentManagerUtils.cpp:61
3  xul.dll  nsGetServiceByContractID::operator const  xpcom/components/nsComponentManagerUtils.cpp:240

Comment 1

[Kershaw Chang [:kershaw]]

I think we can log the JS location to find out what code tries to create channel during shutdown.

Comment 2

[BugBot [:suhaib / :marco]]

The bug is linked to a topcrash signature, which matches the following criterion:

• Top 20 desktop browser crashes on beta

:edgul, could you consider increasing the severity of this top-crash bug?

For more information, please visit BugBot documentation.

Comment 3

[edgul]

Kershaw, thoughts on raising severity?

Comment 4

[Kershaw Chang [:kershaw]]

(In reply to Ed Guloien [:edgul] from comment #3)

Kershaw, thoughts on raising severity?

This crash happens during shutdown, so a user might not notice this.
I think we can leave this as S3.

Comment 5

[Andrew McCreight [:mccr8]]

It is also a diagnostic assert, so it won't affect release users.

Comment 6

[BugBot [:suhaib / :marco]]

Based on the topcrash criteria, the crash signature linked to this bug is not a topcrash signature anymore.

For more information, please visit BugBot documentation.

Comment 7

[BugBot [:suhaib / :marco]]

Sorry for removing the keyword earlier but there is a recent change in the ranking, so the bug is again linked to a topcrash signature, which matches the following criterion:

• Top 20 desktop browser crashes on beta

For more information, please visit BugBot documentation.

Comment 8

[BugBot [:suhaib / :marco]]

Based on the topcrash criteria, the crash signature linked to this bug is not a topcrash signature anymore.

For more information, please visit BugBot documentation.

Comment 9

[Valentin Gosu [:valentin]]

It seems a bunch of these are happening through dom/xhr/XMLHttpRequestMainThread.cpp:2539 calling NS_NewChannel after shutdown.
We should add a check to NS_NewChannel and return error during shutdown.

Comment 10

[Valentin Gosu [:valentin]]

Attachment: Bug 1840182 - Don't instantiate nsHttpHandler during shutdown r=sunil

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d588407829f1
Don't instantiate nsHttpHandler during shutdown r=sunil

Comment 12

[Norisz Fay [:noriszfay]]

Backed out for causing Wd process crash failures

Backout link

Push with failures

Failure log

Comment 13

[BugBot [:suhaib / :marco]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:valentin, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 14

[Valentin Gosu [:valentin]]

Attachment: Bug 1840182 - Do not create new XHR channel during shutdown r=#necko

Comment 15

[Valentin Gosu [:valentin]]

Attachment: Bug 1840182 - Do not create channels during shutdown - NetworkConnectivityService r=#necko

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5526248c0be2
Do not create new XHR channel during shutdown r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/22d329ce0ffc
Do not create channels during shutdown - NetworkConnectivityService r=necko-reviewers,kershaw

Comment 17

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/5526248c0be2
https://hg.mozilla.org/mozilla-central/rev/22d329ce0ffc

Comment 18

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:valentin, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox128 to wontfix.

For more information, please visit BugBot documentation.