Align ui-icons naming with the design system
Categories
(Fenix :: General, task, P3)
Tracking
(firefox117 fixed)
| Tracking | Status | |
|---|---|---|
| firefox117 | --- | fixed |
People
(Reporter: gl, Assigned: gl)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
Refactor the existing icon naming in ui-icons to align with the new icon naming https://github.com/FirefoxUX/acorn-icons
https://acorn.firefox.com/latest/styles/iconography.html
Currently, icons from the design system can be found in https://github.com/FirefoxUX/acorn-icons/tree/main/icons/mobile. We're looking to migrate our existing icon naming to align with how the design system names them. Specifically, we are still looking to preserve our existing "mozac_ic_" prefix, but with the icon naming as seen in the repo. An example change here would be to rename "mozac_ic_close" to "mozac_ic_cross_24" since cross is the naming used in the iconography.
|
||
Comment 1•1 year ago
|
||
|
|
||
Comment 2•1 year ago
|
||
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/1e7866904f7216c01cc58f2fc636f9139980dad5
[main] Bug 1840210 - Rename mozac_ic_add_to_homescreen to mozac_ic_add_to_homescreen_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/f25df2d00dd6fc0afdd0ae7ec46ee31ad8351efa
[main] Bug 1840210 - Rename mozac_ic_close to mozac_ic_cross_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/773540ce9bcca7a295aa70f6451260f2c0289c61
[main] Bug 1840210 - Rename mozac_ic_arrowhead_down to mozac_ic_chevron_down_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/8ebff2e3ed3dca4976786de2241b4bf30750061f
[main] Bug 1840210 - Rename mozac_ic_arrowhead_right to mozac_ic_chevron_right_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/a83aab84496ea09a4205445734e742a7840ffd9e
[main] Bug 1840210 - Rename mozac_ic_arrowhead_up to mozac_ic_chevron_up_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/0c1877cbf9ccba8ed36b903cf1914fdc27e370b4
[main] Bug 1840210 - Rename mozac_ic_check to mozac_ic_checkmark_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/3f840c6fe9212e28851d087f3f9b8ebb8b2e5c69
[main] Bug 1840210 - Rename mozac_ic_autoplay_blocked to mozac_ic_autoplay_slash_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/436a54b60f9264342984e1c7c3ede6a1cd047844
[main] Bug 1840210 - Rename mozac_ic_back to mozac_ic_back_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/17e8a857bb5785b338919512b545858ccea13769
[main] Bug 1840210 - Rename mozac_ic_clear to mozac_ic_cross_circle_fill_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/54baafcfb9e27ad6631358a99db4273c3f6c618a
[main] Bug 1840210 - Rename mozac_ic_delete to mozac_ic_delete_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/97c5f4cbdcba30af21a5e47b9e26d363a450de52
[main] Bug 1840210 - Rename mozac_ic_device_desktop to mozac_ic_device_desktop_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/dd8da86d6a1b0d7e232d11a225d8639f7146e19f
[main] Bug 1840210 - Rename mozac_ic_device_mobile to mozac_ic_device_mobile_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/fb5098e523f748088c9963fd51cbdf8efe7966eb
[main] Bug 1840210 - Rename mozac_ic_download to mozac_ic_download_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/741e9dcc012daffc334119a0d6cc75e0b57c0abd
[main] Bug 1840210 - Rename mozac_ic_edit_suggestion to mozac_ic_append_up_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/699b9d8497463b495a363e8c63f69806a7651c28
[main] Bug 1840210 - Rename mozac_ic_extensions to mozac_ic_extension_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/000c1e5d0a27aaafdaac07974422db67dc6ae3d6
[main] Bug 1840210 - Rename mozac_ic_fingerprint to mozac_ic_fingerprinter_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/e366b52e57053907dde2c884aa2e604f82cafb89
[main] Bug 1840210 - Rename mozac_ic_forward to mozac_ic_forward_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/4fd9c8659f3031f5639c42c86687c7de9874ec6d
[main] Bug 1840210 - Rename mozac_ic_globe to mozac_ic_globe_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/d9f29eaac55203bb0b5282923cd5e98d565a13d4
[main] Bug 1840210 - Rename mozac_ic_help to mozac_ic_help_circle_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/e8781d953fb1e6cf49a5169f4a450c33fe2841e8
[main] Bug 1840210 - Rename mozac_ic_home to mozac_ic_home_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/3dc71892c3204795323a7eaad4831c03a1d5925b
[main] Bug 1840210 - Rename mozac_ic_info to mozac_ic_information_fill_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/0d754c03226bf1f89512ec9f88adc9221c024e93
[main] Bug 1840210 - Rename mozac_ic_information to mozac_ic_information_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/5c5fe501fde925bbcce77cf4b855c17e59942f1c
[main] Bug 1840210 - Rename mozac_ic_link to mozac_ic_link_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/1238721c17a675772af243c17736247931666137
[main] Bug 1840210 - Rename mozac_ic_close_20 to mozac_ic_cross_20
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/64cf39cee5c579814738c41838df1823ab15af46
[main] Bug 1840210 - Rename mozac_ic_location to mozac_ic_location_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/72567968bfd2985df1fd39d0b359354e9164baff
[main] Bug 1840210 - Rename mozac_ic_lock to mozac_ic_lock_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/b3ca1d9eec778f6e4b7231186a1c5ec01c90d829
[main] Bug 1840210 - Rename mozac_ic_login to mozac_ic_login_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/e6cb9cc9b4becc950a74f6889852e81eea8616cd
[main] Bug 1840210 - Rename mozac_ic_menu to mozac_ic_ellipsis_vertical_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/1380b31566b476cda3cd6989c8c894ddd0c2e797
[main] Bug 1840210 - Rename mozac_ic_microphone to mozac_ic_microphone_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/7a22057e0b54e2ff12e9d175e12b74618cf8e59a
[main] Bug 1840210 - Rename mozac_ic_new to mozac_ic_plus_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/a2b4ac8fb72d8ebbea93acbaa57eed097a999f2d
[main] Bug 1840210 - Rename mozac_ic_notification to mozac_ic_notification_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/0b6290aea3f57fdcf6a535389d8ca8b6e2436fab
[main] Bug 1840210 - Rename mozac_ic_password_hide to mozac_ic_eye_slash_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/fb977eb0f496458241a855393a6ceab70efb6ca2
[main] Bug 1840210 - Rename mozac_ic_password_reveal to mozac_ic_eye_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/d5d102574faf82b24a477bc1267b3e38670af785
[main] Bug 1840210 - Rename mozac_ic_pin to mozac_ic_pin_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/79ab10eda594fd2b285dcfa984aee18c51953a15
[main] Bug 1840210 - Rename mozac_ic_pin_remove to mozac_ic_pin_slash_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/e51f098b8d61f8b12fa1c2976a77a6cfbfee6678
[main] Bug 1840210 - Rename mozac_ic_private_browsing to mozac_ic_private_mode_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/73397ace3b7fcf34a05275632582bec530c193cf
[main] Bug 1840210 - Rename mozac_ic_quit to mozac_ic_cross_circle_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/a175578a298ca378579eb299b6f29825ed9a9289
[main] Bug 1840210 - Rename mozac_ic_reader_mode to mozac_ic_reader_view_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/9bc1cf8f10d967deea82783834ac435f11f57c39
[main] Bug 1840210 - Rename mozac_ic_refresh to mozac_ic_arrow_clockwise_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/ac16b886c98199a6408dcae19e58b1f1c555c3ee
[main] Bug 1840210 - Rename mozac_ic_search to mozac_ic_search_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/39cbadc2e7f3772acc9db6c55f6389643ba508fc
[main] Bug 1840210 - Rename mozac_ic_share to mozac_ic_share_android_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/0f6670354cf85b942d4cebaa4f5f550c7698ef3d
[main] Bug 1840210 - Rename mozac_ic_video to mozac_ic_camera_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/fc8e5f82d89c9d5e08d5e4f741b6341d25423228
[main] Bug 1840210 - Rename mozac_ic_shield to mozac_ic_shield_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/59f75af3a7609a289174fc5413f0352a32dad9c1
[main] Bug 1840210 - Rename mozac_ic_warning to mozac_ic_warning_fill_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/e97649cafae2adb65d99e22efe351c67139c1f24
[main] Bug 1840210 - Rename mozac_ic_pin_filled_2 to mozac_ic_pin_fill_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/ef362836c38e287d8383d0ec7661f084ca868773
[main] Bug 1840210 - Rename mozac_ic_settings to mozac_ic_settings_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/917ae656871a4d420aa2ffcc713579e9e70df3cd
[main] Bug 1840210 - Rename mozac_ic_shield_disabled to mozac_ic_shield_slash_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/0e533a384608c500882ad8c2c549b8052eb119f9
[main] Bug 1840210 - Rename mozac_ic_storage to mozac_ic_storage_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/2bf38b4a2b55b2c0fea27cd62f001211ce022224
[main] Bug 1840210 - Add changelog of the list of icon name changes
|
Assignee | |
Comment 3•1 year ago
•
|
||
There shouldn't be much QA here since this is just icon filenames being renamed.
|
|
||
Comment 4•1 year ago
|
||
|
|
||
Comment 5•1 year ago
|
||
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/4829febb31416b8d0cb38f59ff3ac51a1fe073c8
[main] Bug 1840210 - Rename mozac_ic_cookies to mozac_ic_cookies_24
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/35f1f6297b3f6d352f86c41c8041638013df72d5
[main] Bug 1840210 - Rename mozac_ic_sync to mozac_ic_sync_24
|
||
Updated•1 year ago
|
Description
•