1840390 - Fix issues with "Edit breakpoint" keyboard shortcuts in the Debugger

Status: NEW

(DevTools :: Debugger, defect, P2)

Description

[davidxtejada]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:109.0) Gecko/20100101 Firefox/114.0

Steps to reproduce:

Place the cursor inside a file in the sources panel of the devtools and press the shortcut for creating a new log point (cmd-shift-y).

Actual results:

The input for creating a conditional breakpoint appears. Additionally, if you try to save this conditional breakpoint it fails. Regardless if you used the shortcut for creating a conditional breakpoint or a log point.

Expected results:

The input for creating a log point should have appeared.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'DevTools::Debugger' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Alexandre Poirot [:ochameau]]

Something is wrong when processing the key shortcuts over there:
https://searchfox.org/mozilla-central/rev/c0adc2160976e2c118e2e5709d08aac071fddce9/devtools/client/debugger/src/components/Editor/index.js#249-252
We should be passing true as second argument to openConditionalPanel:
https://searchfox.org/mozilla-central/rev/c0adc2160976e2c118e2e5709d08aac071fddce9/devtools/client/debugger/src/components/Editor/index.js#332-339
But as this method is used for both conditional and log points this should be fine tuned.

Otherwise, I was wondering what was going around with the accesskey being set to "L":
https://searchfox.org/mozilla-central/rev/c0adc2160976e2c118e2e5709d08aac071fddce9/devtools/client/locales/en-US/debugger.properties#469-472
Whereas the key shortcut is set to "CmdOrCtrl+Shift+Y":
https://searchfox.org/mozilla-central/rev/c0adc2160976e2c118e2e5709d08aac071fddce9/devtools/client/locales/en-US/debugger.properties#275-279
I'm not sure I'm able to trigger this "L" accesskey??

Comment 3

[Julian Descottes [:jdescottes]]

It seems both conditional breakpoint and logpoint shortcuts are broken (or work unexpectedly).
Also the current documentation is a bit misleading, we should clarify the exact behaviour