1840453 - Retry when the API is unavailable

Status: RESOLVED FIXED

(Firefox Graveyard :: Shopping, task, P2)

Description

[Fred Chasen [:fchasen]]

Update the API client to automatically retry when the API is unreachable (and we are online) or returns any 5XX error code.

This should probably be ~3 try, with an exponential back off?

Comment 1

[Fred Chasen [:fchasen]]

Will also need to track request state with this to prevent from calling multiple times.

Comment 2

[Fred Chasen [:fchasen]]

Attachment: Bug 1840453 - Retry Shopping API after 500 errors r=#shopping-reviewers!

• ShoppingProduct API client will retry 3 times when the API returns a 500 error
• Exponentially increasing back off wait with each retry
• Added some random jitter to prevent all request from retrying at the same time
• Added tests for 400 errors returned by API
• Made request method public so it can be tested and used directly

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b59d0cee3f2d
Retry Shopping API after 500 errors r=shopping-reviewers,jhirsch,Gijs

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b59d0cee3f2d