1840510 - Add ACVP test vectors to the repository

Status: RESOLVED FIXED

(NSS :: Test, enhancement)

Description

[Iaroslav Gridin]

Currently vectors included with acvp-rust are used, this stores them in the repository for easier maintenance.

These vectors cover AES(GCM), ECDSA, RSA, SHA256 and big number operations.
This includes both vectors from ACVP and ones produced by fuzzing by acvp-rust.
The latter do not necessarily verify the correctness but ensure most code is covered and behaves normally during test execution.

Comment 1

[Iaroslav Gridin]

Attachment: Bug 1840510: Add ACVP test vectors to the repository

These cover AES(GCM), ECDSA, RSA, SHA256 and big number operations.
This includes both vectors from ACVP and ones produced by fuzzing by acvp-rust.
The latter do not necessarily verify the correctness but ensure most code is covered and behaves normally during test execution.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:iaroslav.gridin, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 3

[John Schanck [:jschanck]]

https://hg.mozilla.org/projects/nss/rev/ffb50bee6680491dddbdc9a3fa723c86332f15f9

Comment 4

[John Schanck [:jschanck]]

Some of the fuzzer generated ECDSA tests are failing with the new HACL* P-256 code. I think it's a problem with the old code rather than the new code---it looks like the old code accepted private keys that were shorter than 32 bytes.

https://treeherder.mozilla.org/jobs?repo=nss&selectedTaskRun=RIVMo_WRRV-t1BzKadmmEw.0

Comment 5

[Iaroslav Gridin]

(In reply to John Schanck [:jschanck] from comment #4)

Some of the fuzzer generated ECDSA tests are failing with the new HACL* P-256 code. I think it's a problem with the old code rather than the new code---it looks like the old code accepted private keys that were shorter than 32 bytes.

https://treeherder.mozilla.org/jobs?repo=nss&selectedTaskRun=RIVMo_WRRV-t1BzKadmmEw.0

Thanks for the notice, fixed in a patch.

Comment 6

[Iaroslav Gridin]

Attachment: Bug 1840510: update ACVP fuzzed test vector: refuzzed with current NSS

Comment 7

[John Schanck [:jschanck]]

https://hg.mozilla.org/projects/nss/rev/da1cde22e8442639a86ca6a4ce541956fcdce4be