1840517 - Build Addons picker screen for about:welcome

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Emily McMinn :emcminn]

Attachment: Screenshot 2023-06-26 at 8.31.00 PM.png

Add a screen that has a selection of add-ons that can be installed directly from the screen.

This first version will allow us to experiment with including addons in new user onboarding, and as an MVP will

• Render an addons screen in about:welcome
• Render addon information directly from screen JSON (a later version can fetch from RTAMO)
• Allow the addons to be installed from the about:welcome screen.

Based on in progress Figma

Comment 1

[Emily McMinn :emcminn]

Attachment: Bug 1840517 - Render addons screen & tiles, and allow addons to be intalled from addonspicker component

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ae88f81ac4a
Render addons screen & tiles, and allow addons to be intalled from addonspicker component r=desktop-theme-reviewers,omc-reviewers,dao,aminomancer

Comment 3

[Iulian Moraru]

Backed out for causing newtab failures.
LATER EDIT: also please take a look at this TV failures before re-landing this.

• Push with failures

• Failure log

• Backout link

[task 2023-07-12T20:18:45.098Z] TEST-START | bundles
[task 2023-07-12T20:18:53.220Z] Browserslist: caniuse-lite is outdated. Please run:
[task 2023-07-12T20:18:53.220Z]   npx browserslist@latest --update-db
[task 2023-07-12T20:18:53.220Z]   Why you should do it regularly: https://github.com/browserslist/browserslist#browsers-data-updating
[task 2023-07-12T20:18:53.220Z] Browserslist: caniuse-lite is outdated. Please run:
[task 2023-07-12T20:18:53.220Z]   npx browserslist@latest --update-db
[task 2023-07-12T20:18:53.220Z]   Why you should do it regularly: https://github.com/browserslist/browserslist#browsers-data-updating
[task 2023-07-12T20:18:53.227Z] TEST-UNEXPECTED-FAIL | bundles | About:welcome bundle out of date
[task 2023-07-12T20:18:53.227Z] TEST-START | karma
[task 2023-07-12T20:19:45.278Z] webpack was not included as a framework in karma configuration, setting this automatically...
[task 2023-07-12T20:19:45.278Z] Browserslist: caniuse-lite is outdated. Please run:
[task 2023-07-12T20:19:45.278Z]   npx browserslist@latest --update-db
[task 2023-07-12T20:19:45.278Z]   Why you should do it regularly: https://github.com/browserslist/browserslist#browsers-data-updating
[task 2023-07-12T20:19:45.292Z] TEST-UNEXPECTED-FAIL | karma | Coverage for statements (7.14%) in file /builds/worker/checkouts/gecko/browser/components/newtab/content-src/aboutwelcome/components/AddonsPicker.jsx does not meet per file threshold (62%)
[task 2023-07-12T20:19:45.292Z] TEST-UNEXPECTED-FAIL | karma | Coverage for lines (7.14%) in file /builds/worker/checkouts/gecko/browser/components/newtab/content-src/aboutwelcome/components/AddonsPicker.jsx does not meet per file threshold (60%)
[task 2023-07-12T20:19:45.292Z] TEST-UNEXPECTED-FAIL | karma | Coverage for branches (0%) in file /builds/worker/checkouts/gecko/browser/components/newtab/content-src/aboutwelcome/components/AddonsPicker.jsx does not meet per file threshold (50%)
[task 2023-07-12T20:19:45.292Z] TEST-UNEXPECTED-FAIL | karma | Coverage for functions (0%) in file /builds/worker/checkouts/gecko/browser/components/newtab/content-src/aboutwelcome/components/AddonsPicker.jsx does not meet per file threshold (50%)
[task 2023-07-12T20:19:45.292Z] -----karma stdout below this line---
[task 2023-07-12T20:19:45.293Z] 
[task 2023-07-12T20:19:45.293Z] > activity-streams@1.14.3 testmc:unit
[task 2023-07-12T20:19:45.293Z] > karma start karma.mc.config.js
[task 2023-07-12T20:19:45.293Z] 
[task 2023-07-12T20:19:45.293Z] 
[task 2023-07-12T20:19:45.293Z] START:
<...>

Comment 4

[Emily McMinn :emcminn]

Ahh shoot, I'll look at the coverage. Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/949ab6d791cd
Render addons screen & tiles, and allow addons to be intalled from addonspicker component r=desktop-theme-reviewers,omc-reviewers,dao,aminomancer

Comment 6

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failure on browser_aboutwelcome_multistage_mr.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/45fc89aa9bebccee68248aa301339663d3cf0d1d
Log link: https://treeherder.mozilla.org/logviewer?job_id=422587673&repo=autoland&lineNumber=47895

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/018a47c67bab
Render addons screen & tiles, and allow addons to be intalled from addonspicker component r=desktop-theme-reviewers,omc-reviewers,dao,aminomancer

Comment 8

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/018a47c67bab

Comment 9

[Emily McMinn :emcminn]

Intermittent fixed, and re-landed

Comment 10

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/018a47c67bab

Comment 11

[Marius Coman [:mcoman], Ecosystem QA - PTO until 8th of November, for any requests ping :cmuresan]

I have verified this enhancement using the steps provided in the Test Plan and I can confirm the following:

• The add-ons screen is successfully rendered on the "about:welcome" page.
• The add-on information is successfully displayed.
• The add-ons can be installed directly from the "about:welcome" screen.

Verified using the latest Firefox Beta 117.0b6 (Build ID: 20230810181819) installed on Windows 10 x64, macOS 13.4.1, and Linux Mint 21.1.