Closed Bug 1840532 Opened 2 years ago Closed 1 month ago

Add support for an additional static preferences list in comm-central

Categories

(Core :: Preferences: Backend, task)

task

Tracking

()

RESOLVED FIXED
142 Branch

People

(Reporter: darktrojan, Assigned: darktrojan)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 2 obsolete files)

Sooner or later, we (Thunderbird) are going to want our own static preference list in comm-central, so that we don't have to bother MoCo people every time we want to change something.

I think what I'd do is modify emitCode to take an optional argument, and if it exists, push that through the preprocessor too. But this trips up the group ordering checks. I'm not sure what to do about that.

Assignee: geoff → nobody
Status: ASSIGNED → NEW
Attachment #9341180 - Attachment is obsolete: true

I've been thinking about this again, and I think it can be done with minimal changes to the existing code. A second preferences list can live somewhere in comm-central and generate_static_pref_list.py can create the files. If the StaticPrefListAll.h and StaticPrefsAll.h are given different file names, they then just need to be included in Preferences.cpp wherever the mozilla-central versions are.

I'm less concerned with the Rust side of things at the moment, we'll figure something out when we get there.

Assignee: nobody → geoff
Status: NEW → ASSIGNED
Attachment #9425175 - Attachment description: WIP: Bug 1840532 - Add support for an additional static preferences list in comm-central. → Bug 1840532 - Add support for an additional static preferences list in comm-central. r=glandium
See Also: → 1927029
Attachment #9341180 - Attachment is obsolete: false
Attachment #9341180 - Attachment description: WIP: Bug 1840532 - Add support for an additional static preferences list. → Bug 1840532 - Add support for an additional static preferences list in comm-central. r=glandium
Attachment #9425175 - Attachment is obsolete: true
Attachment #9341180 - Attachment is obsolete: true
Attachment #9425177 - Attachment description: WIP: Bug 1840532 - Add a static preferences list in comm-central. → Bug 1840532 - Add a static preferences list in comm-central. r=#thunderbird-reviewers
Keywords: leave-open
Target Milestone: --- → 141 Branch

This needs to hit comm-central when the changes are merged to mozilla-central.

Pushed by geoff@darktrojan.net:
https://github.com/mozilla-firefox/firefox/commit/6fbc89546bc9
https://hg.mozilla.org/integration/autoland/rev/15f58c67304b
Add support for an additional static preferences list in comm-central. r=glandium

Pushed by abutkovits@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/3c11e679b117 https://hg.mozilla.org/integration/autoland/rev/b796ba4edd06 Revert "Bug 1840532 - Add support for an additional static preferences list in comm-central. r=glandium" for causing python failures.

Yup, I screwed up. :-/

Flags: needinfo?(geoff)
Pushed by geoff@darktrojan.net: https://github.com/mozilla-firefox/firefox/commit/2844b3a34d50 https://hg.mozilla.org/integration/autoland/rev/61eb945e5619 Add support for an additional static preferences list in comm-central. r=glandium
Target Milestone: 141 Branch → 142 Branch

Pushed by vineet@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/abafe6f7f5da
Add a static preferences list in comm-central. r=edicharry

Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Blocks: 1974951
Regressions: 1976639
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: