1840587 - [css-properties-values-api] Prevent wide keywords as initial values.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1840587 - [css-properties-values-api] Prevent CSS-wide keywords as initial values. r=zrhoffman,#style

This is not the whole validation that needs to happen, but we need to do
this anyways for the universal-syntax.

Rename validate_syntax to validate_initial_value since that's what it
does.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1840587 - [css-properties-values-api] Values with references shouldn't be valid initial values. r=zrhoffman,#style

Same, we need this check regardless of the syntax.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1840587 - Improve custom property reference storage. r=zrhoffman,#style

This effectively undoes bug 1506760, preventing the reallocation of the
reference set.

This was done for UA sheet sharing (bug 1474793), but we can handle this
fine now (UA sheets don't have variable references anyways).

Depends on D182170

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/440bb2a35ccf
[css-properties-values-api] Prevent CSS-wide keywords as initial values. r=zrhoffman

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84b19be6711b
[css-properties-values-api] Values with references shouldn't be valid initial values. r=zrhoffman
https://hg.mozilla.org/integration/autoland/rev/e08f40241310
Improve custom property reference storage. r=zrhoffman

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/440bb2a35ccf
https://hg.mozilla.org/mozilla-central/rev/84b19be6711b
https://hg.mozilla.org/mozilla-central/rev/e08f40241310