1840644 - Sync Iterator Helpers proposal implementation to latest spec draft

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1840644 - Part 1: Add callee and args accessors to CallNode. r=#spidermonkey-reviewers!

Add accessors for the callee and the arguments, which makes the code a bit
easier to read when compared to using the BinaryNode left and right
accessors.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1840644 - Part 2: Support allowContentIterWith in array-spread expressions. r=#spidermonkey-reviewers!

[...allowContentIterWith(array, usingIterator)] was evaluated exactly the same
as [...allowContentIter(array)], i.e. the explicit iterator method usingIterator
was ignored.

• Adds BytecodeEmitter::emitIterable() to push the iterator operands on the stack.
• Removes some default parameters to make it more explicit when content iteration is
  disallowed.

Depends on D182232

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1840644 - Part 3: Add allowContentIterWithNext for self-hosting code. r=#spidermonkey-reviewers!

Add allowContentIterWithNext in preparation for the next part. This operation
can be used when both the iterator and its next method have already been
computed.

Depends on D182233

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1840644 - Part 4: Rewrite Iterator Helpers proposal to match current spec draft. r=#spidermonkey-reviewers!

More or less a complete re-implementation to match the current proposal text.
The code has been rewritten to use normal for-of loops instead of performing
manual iteration. This should make it easier to follow the implementation and
needs fewer lines of code.

Depends on D182234

Comment 5

[André Bargull [:anba]]

Attachment: Bug 1840644 - Part 5: Replace self-hosted IteratorClose function with JSOp::CloseIter. r=#spidermonkey-reviewers!

Depends on D182235

Comment 6

[André Bargull [:anba]]

Attachment: Bug 1840644 - Part 6: Enable Iterator Helpers tests from test262. r=#spidermonkey-reviewers!

Depends on D182236

Comment 7

[André Bargull [:anba]]

Attachment: Bug 1840644 - Part 7: Reimport test262 to apply new flags. r=#spidermonkey-reviewers!

Depends on D182237

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3a37fcd2c9d
Part 1: Add callee and args accessors to CallNode. r=spidermonkey-reviewers,dminor
https://hg.mozilla.org/integration/autoland/rev/3d8eb27c8dcf
Part 2: Support allowContentIterWith in array-spread expressions. r=spidermonkey-reviewers,dminor
https://hg.mozilla.org/integration/autoland/rev/567dc198af07
Part 3: Add allowContentIterWithNext for self-hosting code. r=spidermonkey-reviewers,dminor
https://hg.mozilla.org/integration/autoland/rev/f8f18f75269d
Part 4: Rewrite Iterator Helpers proposal to match current spec draft. r=spidermonkey-reviewers,dminor
https://hg.mozilla.org/integration/autoland/rev/a15459ef243d
Part 5: Replace self-hosted IteratorClose function with JSOp::CloseIter. r=spidermonkey-reviewers,dminor
https://hg.mozilla.org/integration/autoland/rev/3ea9299f7ad6
Part 6: Enable Iterator Helpers tests from test262. r=spidermonkey-reviewers,dminor
https://hg.mozilla.org/integration/autoland/rev/781accfc609a
Part 7: Reimport test262 to apply new flags. r=spidermonkey-reviewers,dminor

Comment 9

[Cristina Horotan [:chorotan]]

Backed out 7 changesets (bug 1840644) for causing SM failure at BytecodeEmitter.cpp

Backout: https://hg.mozilla.org/integration/autoland/rev/2ae5f027d056d128412df40b51cb8dbfa3609de2

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=781accfc609a2fd69f8206ee6e7f9307e841ecb2&selectedTaskRun=WILZe1WRRGOme84--QF93w.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=421693355&repo=autoland&lineNumber=2957

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0fbebc734f3a
Part 1: Add callee and args accessors to CallNode. r=spidermonkey-reviewers,dminor
https://hg.mozilla.org/integration/autoland/rev/a346d4afdc4e
Part 2: Support allowContentIterWith in array-spread expressions. r=spidermonkey-reviewers,dminor
https://hg.mozilla.org/integration/autoland/rev/af9e47636935
Part 3: Add allowContentIterWithNext for self-hosting code. r=spidermonkey-reviewers,dminor
https://hg.mozilla.org/integration/autoland/rev/6a662868b8b3
Part 4: Rewrite Iterator Helpers proposal to match current spec draft. r=spidermonkey-reviewers,dminor
https://hg.mozilla.org/integration/autoland/rev/6029d99b6795
Part 5: Replace self-hosted IteratorClose function with JSOp::CloseIter. r=spidermonkey-reviewers,dminor
https://hg.mozilla.org/integration/autoland/rev/ad2a1c8d112a
Part 6: Enable Iterator Helpers tests from test262. r=spidermonkey-reviewers,dminor
https://hg.mozilla.org/integration/autoland/rev/5b919b11b30b
Part 7: Reimport test262 to apply new flags. r=spidermonkey-reviewers,dminor

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/0fbebc734f3a
https://hg.mozilla.org/mozilla-central/rev/a346d4afdc4e
https://hg.mozilla.org/mozilla-central/rev/af9e47636935
https://hg.mozilla.org/mozilla-central/rev/6a662868b8b3
https://hg.mozilla.org/mozilla-central/rev/6029d99b6795
https://hg.mozilla.org/mozilla-central/rev/ad2a1c8d112a
https://hg.mozilla.org/mozilla-central/rev/5b919b11b30b