1840658 - Check or Add Exposure Event for PDF Toolbar Experiment

Status: RESOLVED FIXED

(GeckoView :: PDF Viewer, task, P1)

Description

[Olivia Hall [:olivia]]

We need to setup an exposure event for the PDF.js Toolbar experiment to know what users encountered the feature.

Docs:

• Enrollment v. Exposure
• Defining Exposure Signals
• recordExposureEvent()
• pdfjs_used

Comment 1

[Olivia Hall [:olivia]]

After chatting with :royang:,

I think we will need to record an exposure event around here in PDF.js for both the Download and Open in App features similar to this example.

(I'm still researching what needs to occur. Moving this back to the viewer component, since it looks like we will need to do work on that side.)

Comment 2

[Olivia Hall [:olivia]]

I think we might only need one exposure event after onViewerIsUsed.

Early testing seems to indicate that using the Gecko call of NimbusFeatures.pdfjs.recordExposureEvent(); might not work and we will need to create a workaround. Will find out more during Nimbus office hours.

Comment 3

[Olivia Hall [:olivia]]

Confirmed that we will need to setup an API similar to onGetNimbusFeature (GV side and Fenix side) to send an exposure event for Android from the Gecko side.

Comment 4

[:shell escalante]

Olivia - do you know if this is landing for 117? Looking at the notes - it sounds like we want to ping James Hugman as a reviewer.

That looks like the last step to launch this experiment https://experimenter.services.mozilla.com/nimbus/android-pdf-new-capabilities-experiment/edit/overview (since that passed QA!)

Comment 5

[Olivia Hall [:olivia]]

Hi Shell, thanks for reaching out! This will be landing a little late in 118 and has a few dependencies that we will need to land first.

• Bug 1843592 - Adds a runtime ExperimentDelegate to communicate between Fenix and GeckoView
  • part 1 is ready to land, but waiting until after the 117 code freeze, and part 2 is finishing up review.
• Bug 1845824 - Adds a way for the GeckoView JS side to communicate with the Java ExperimentDelegate
  • I have a patch locally I'm finishing the tests up on, hope to land early 118
• Bug 1845824 (this bug) - Will connect the work from bug 1845824 into the PDF code to send the exposure event

Good news is that the ExperimentDelegate background work will be helpful for GeckoView-side mobile experiments in the future and we won't have to set it up for the next experiment!

Comment 6

[Olivia Hall [:olivia]]

Attachment: Bug 1840658 - Add Exposure Event for PDF Toolbar Experiment

Connects the new ExperimentDelegate to the GeckoViewPdfjsParent for
getting Nimbus features and sending exposure events. Sends an exposure
event when the PDF is loaded.

Depends on D184841

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a892cc5b6a61
Add Exposure Event for PDF Toolbar Experiment r=geckoview-reviewers,calixte,owlish,tthibaud

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a892cc5b6a61