1840746 - SVG patternTransform translate uses wrong units

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Timwi]

Attachment: actual_rendering.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/114.0

Steps to reproduce:

Consider the following SVG code:

	<svg viewBox='0 0 2 2' xmlns='http://www.w3.org/2000/svg'>
		<defs>
			<pattern id="r" patternTransform="translate(.5 .5)" patternUnits="userSpaceOnUse" width="2" height="2">
				<path d="M0 0h1v1H0zM1 1h1v1H1z" />
			</pattern>
		</defs>
		<rect x='0' y='0' width='2' height='2' fill='url(#r)' />
	</svg>

Actual results:

See attached screenshot actual_rendering.png. Firefox appears to interpret the “.5” in the patternTransform as a miniscule unit that amounts to just one pixel offset (see the thin black line along the top and left edge).

Expected results:

See attached screenshot expected_rendering.png. Firefox is supposed to interpret the “.5” as a unit relative to the size of the pattern. This expected rendering is produced by both Chrome and Inkscape.

Comment 1

[Timwi]

Attachment: expected_rendering.png

Comment 2

[Timwi]

Attachment: test_case.svg

Test case SVG code.

Comment 3

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e05949a302a42cab9583e628b2b573b9490228a8&tochange=b5806e6bb8f78cb705c008b8b1a42dc4b56941b4

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

:longsonr, since you are the author of the regressor, bug 1193586, could you take a look?

For more information, please visit BugBot documentation.

Comment 5

[Robert Longson [:longsonr]]

Attachment: Bug 1840746 - SVG patternTransform translate uses wrong units r=emilio

Comment 6

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=cebf78d6f54497cc4897658e4be7bb8634c593bb

Comment 7

[Pascal Chevrel:pascalc]

Looks like a good candidate for the planned dot release, tracking for 115.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24fa74f3ab1c
SVG patternTransform translate uses wrong units r=emilio

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/40874 for changes under testing/web-platform/tests

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/24fa74f3ab1c

Comment 11

[Robert Longson [:longsonr]]

Comment on attachment 9342019 [details]
Bug 1840746 - SVG patternTransform translate uses wrong units r=emilio

Beta/Release Uplift Approval Request

• User impact if declined: incorrect patterns when patternTransform is used
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): reverts one line of code to what it was in Firefox 114
• String changes made/needed:
• Is Android affected?: Yes

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 13

[Dianna Smith [:diannaS]]

Comment on attachment 9342019 [details]
Bug 1840746 - SVG patternTransform translate uses wrong units r=emilio

Approved for 116.0b2

Comment 14

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/511ef25b1765

Comment 15

[Donal Meehan [:dmeehan]]

Comment on attachment 9342019 [details]
Bug 1840746 - SVG patternTransform translate uses wrong units r=emilio

Approved for 115.0.2
Approved for 115.0.2esr

Comment 16

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/7bd97f33c21a

Comment 17

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/5e419f99eb5b

Comment 18

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/96cc0bef834c