1840776 - CSS Rules Inspector doesn't work when CSS Custom Highlight API is enabled

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect, P2)

Description

[Gregory Pappas [:gregp]]

Attachment: blank_rules_inspector.png

Steps to reproduce:

1. Navigate to about:config
2. Set dom.customHighlightAPI.enabled to true
3. Open DevTools
4. Select 'Inspector' tab

Actual results:
Rules panel is blank

Expected results:
Rules panel is not blank

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Here's the error we can see in such case:

Unhandled pseudo-element ::highlight
  resource://devtools/server/actors/page-style.js", 716

which comes from https://searchfox.org/mozilla-central/rev/c0adc2160976e2c118e2e5709d08aac071fddce9/devtools/server/actors/page-style.js#683-685,715-716

// eslint-disable-next-line complexity
_pseudoIsRelevant(node, pseudo) {
  switch (pseudo) {
...
    default:
      throw Error("Unhandled pseudo-element " + pseudo);

Comment 2

[Julian Descottes [:jdescottes]]

Hi Jan, do you have any timeline to flip the preference dom.customHighlightAPI.enabled to true, so that we can prioritize this DevTools issue?

Comment 3

[Jan Jaeschke [:jjaschke]]

Hi, I am planning to flip the pref as soon as the code freeze for 116 is over. So likely next week :)

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1840776 - [devtools] Fix inspector crash on ::highlight. r=#devtools-reviewers.

This prevent the rule view crashing when dom.customHighlightAPI.enabled is set
to true.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d5a9a3fc271
[devtools] Fix inspector crash on ::highlight. r=devtools-reviewers,jdescottes.

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/0d5a9a3fc271