Closed Bug 1840781 Opened 5 months ago Closed 5 months ago

[css-nesting] Ship CSS Nesting

Categories

(Core :: CSS Parsing and Computation, task)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
VERIFIED FIXED
Milestone:
117 Branch
Tracking Flags:
Tracking Status
relnote-firefox --- 117+
firefox117 --- verified

People

(Reporter: sebo, Assigned: emilio)

References

(Depends on 1 open bug,
URL
)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Bug 1840781 - [css-nesting] Enable by default. r=#style,#layout
48 bytes, text/x-phabricator-request
Details | Review
No description provided.

After the pending test fixes (bug 1843349) we only fail tests due to two
reasons:

  • :has() being unsupported. Not related to the feature itself.

  • The nesting selector being inside another (invalid) forgiving
    selector, e.g. :is(!&) not being preserved.

The later is pretty much in edge-case-land, and I think
https://github.com/w3c/csswg-drafts/issues/8356 would be more consistent
rather than doing it only when an & is found (which is very very weird).

So I wouldn't want to block on that. Let's let it ride the trains.

Assignee: nobody → emilio
Status: NEW → ASSIGNED
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/88d3fbc7589e
[css-nesting] Enable by default. r=boris

https://hg.mozilla.org/mozilla-central/rev/88d3fbc7589e

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
status-firefox117: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch
Keywords: dev-doc-needed
Duplicate of this bug: 1843282

Verified in today's beta simulation push

Status: RESOLVED → VERIFIED
status-firefox117: fixed → verified

Should we call this out in the Fx117 relnotes?

Flags: needinfo?(emilio)

Release Note Request (optional, but appreciated)
[Why is this notable]: Implements improved nesting behavior, see the dev-platform thread for details
[Affects Firefox for Android]: Yes
[Suggested wording]: Support for improved CSS nesting is enabled by default. We could go into more technical details I guess but the email thread is probably better for that.
[Links (documentation, blog post, etc)]: Probably https://groups.google.com/a/mozilla.org/g/dev-platform/c/2oBSRgIRf80 is ok? Apparently MDN doesn't have great documentation for this?

relnote-firefox: --- → ?
Flags: needinfo?(emilio)

Added to the Fx117 relnotes.

relnote-firefox: ? → 117+

A number of pages have been created:

  • /en-US/docs/Web/CSS/CSS_nesting
  • /en-US/docs/Web/CSS/Nesting_selector
  • /en-US/docs/Web/CSS/CSS_nesting/Using_CSS_nesting
  • /en-US/docs/Web/CSS/CSS_nesting/Nesting_and_specificity
  • /en-US/docs/Web/CSS/CSS_nesting/Nesting_at-rules

Added to the release notes for Firefox 117:

  • /en-US/docs/Mozilla/Firefox/Releases/117

Updated the CSSRef.ejs page in Yari to show the new pages in Guides

Associated Pull Requests

Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.