1840809 - Replace nsHttpChannel::mRedirectFuncStack

Status: NEW

(Core :: Networking, enhancement, P3)

Description

[Sunil Mayya]

The listeners of the channel are notified about redirects using the AsyncOnChannelRedirect() interface. The listeners check and signals its approval for redirect using nsIAsyncVerifyRedirectCallback::OnRedirectVerifyCallback interface.
nsHttpChannel::mRedirectFuncStack is an array of callbacks to be called after the listeners signaled their approval for redirect. Storing the callbacks in an array can cause problem while debugging crashes i.e. no proper backtrace.
We need to devise a better solution to store/retrieve the function callbacks to be called upon successful redirect notification from the listener.

Comment 1

[Valentin Gosu [:valentin] (he/him) {{ FYI: OOO 14 June - 4 August }}]

My main problem with that code is that it's an array of function pointers.
If it were an array of std::function I think that might help a bit with the readability of stack traces.