Closed Bug 1840813 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 40786 - Use required Image Capture constraints to overconstrain

Categories

(Core :: Audio/Video: Recording, task, P4)

Product:
Core
Component:
Audio/Video: Recording
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
117 Branch
Tracking Flags:
Tracking Status
firefox117 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 40786 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/40786
Details from upstream follow.

Eero Häkkinen <eero.hakkinen@intel.com> wrote:

Use required Image Capture constraints to overconstrain

Advanced constraints sets passed to the MediaStreamTrack
applyConstraints method should either be applied or ignored. They should
never cause an OverconstrainedError to be thrown. This CL fixed Image
Capture tests to use required constraints instead of advanced
constrained to throw an OverconstrainedError.

Bug: 1408091
Change-Id: Ib23348c81ec73fd8f2594baabf3433cfefadcd06

Reviewed-on: https://chromium-review.googlesource.com/4651034
WPT-Export-Revision: db8f41fe3af51d2b5a8e2006a01db340dca359fd

Component: web-platform-tests → Audio/Video: Recording
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 3 subtests

Status Summary

Firefox

OK : 1
PASS : 24
FAIL : 34
ERROR: 3

Chrome

OK : 4
PASS : 57
FAIL : 1

Safari

OK : 1
PASS : 26
FAIL : 32
ERROR: 3

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

  • /mediacapture-image/MediaStreamTrack-applyConstraints-fast.html [wpt.fyi]
    • MediaStreamTrack.applyConstraints(): FAIL (Chrome: PASS, Safari: PASS)
    • MediaStreamTrack.applyConstraints({advanced: []}): FAIL (Chrome: PASS, Safari: PASS)
    • MediaStreamTrack.applyConstraints() with unsupported constraint: FAIL (Chrome: PASS, Safari: FAIL)
  • /mediacapture-image/MediaStreamTrack-applyConstraints-getSettings.https.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
    • exercises an applyConstraints() - getSettings() cycle with PTZ permission granted: FAIL (Chrome: PASS, Safari: FAIL)
    • exercises an applyConstraints() with required constraints with PTZ permission denied: FAIL (Chrome: PASS, Safari: FAIL)
    • exercises an applyConstraints() with ideal constraints with PTZ permission denied: FAIL (Chrome: PASS, Safari: FAIL)
    • exercises an applyConstraints() with advances constraints with PTZ permission denied: FAIL (Chrome: FAIL, Safari: FAIL)
  • /mediacapture-image/MediaStreamTrack-applyConstraints-reject.https.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
    • MediaStreamTrack-applyConstraints-reject: FAIL (Chrome: PASS, Safari: FAIL)
    • MediaStreamTrack-applyConstraints-reject 1: FAIL (Chrome: PASS, Safari: FAIL)
    • MediaStreamTrack-applyConstraints-reject 2: FAIL (Chrome: PASS, Safari: FAIL)
    • MediaStreamTrack-applyConstraints-reject 3: FAIL (Chrome: PASS, Safari: FAIL)
    • MediaStreamTrack-applyConstraints-reject 4: FAIL (Chrome: PASS, Safari: FAIL)
    • MediaStreamTrack-applyConstraints-reject 5: FAIL (Chrome: PASS, Safari: FAIL)
    • MediaStreamTrack-applyConstraints-reject 6: FAIL (Chrome: PASS, Safari: FAIL)
    • MediaStreamTrack-applyConstraints-reject 7: FAIL (Chrome: PASS, Safari: FAIL)
    • MediaStreamTrack-applyConstraints-reject 8: FAIL (Chrome: PASS, Safari: FAIL)
    • MediaStreamTrack-applyConstraints-reject 9: FAIL (Chrome: PASS, Safari: FAIL)
    • MediaStreamTrack-applyConstraints-reject 10: FAIL (Chrome: PASS, Safari: FAIL)
    • MediaStreamTrack-applyConstraints-reject 11: FAIL (Chrome: PASS, Safari: FAIL)
    • MediaStreamTrack-applyConstraints-reject 12: FAIL (Chrome: PASS, Safari: FAIL)
    • MediaStreamTrack-applyConstraints-reject 13: FAIL (Chrome: PASS, Safari: FAIL)
    • MediaStreamTrack-applyConstraints-reject 14: FAIL (Chrome: PASS, Safari: FAIL)
    • MediaStreamTrack-applyConstraints-reject 15: FAIL (Chrome: PASS, Safari: FAIL)
    • MediaStreamTrack-applyConstraints-reject 16: FAIL (Chrome: PASS, Safari: FAIL)
    • MediaStreamTrack-applyConstraints-reject 17: FAIL (Chrome: PASS, Safari: FAIL)
    • MediaStreamTrack-applyConstraints-reject 18: FAIL (Chrome: PASS, Safari: FAIL)
    • MediaStreamTrack-applyConstraints-reject 19: FAIL (Chrome: PASS, Safari: FAIL)
    • MediaStreamTrack-applyConstraints-reject 20: FAIL (Chrome: PASS, Safari: FAIL)
    • MediaStreamTrack-applyConstraints-reject 21: FAIL (Chrome: PASS, Safari: FAIL)
    • MediaStreamTrack-applyConstraints-reject 22: FAIL (Chrome: PASS, Safari: FAIL)
    • MediaStreamTrack-applyConstraints-reject 23: FAIL (Chrome: PASS, Safari: FAIL)
  • /mediacapture-image/MediaStreamTrack-clone.https.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
    • checks MediaStreamTrack.clone() gets same applied constraints: FAIL (Chrome: PASS, Safari: FAIL)
    • checks MediaStreamTrack.clone() gets same settings: FAIL (Chrome: PASS, Safari: FAIL)
    • checks MediaStreamTrack.clone() gets same capabilities: FAIL (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8099d4d60b6d [wpt PR 40786] - Use required Image Capture constraints to overconstrain, a=testonly https://hg.mozilla.org/integration/autoland/rev/a9096dc6740e [wpt PR 40786] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/8099d4d60b6d
https://hg.mozilla.org/mozilla-central/rev/a9096dc6740e

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox117: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch
You need to log in before you can comment on or make changes to this bug.