1840839 - Make it possible to construct `JS::CompileOptions` which reflects user prefs, without having JS context?

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[Tooru Fujisawa [:arai]]

Currently the JS::CompileOptions is constructed from JSContext, by copying the user pref from JS::ContextOptions and JS::RealmCreationOptions.

JS::CompileOptions::CompileOptions

Currently the user prefs are mirrored to realm options and context options in
xpc::SetPrefableRealmOptions and xpc::SetPrefableContextOptions.

if we can factor out compilation-specific options (such as new syntax) and handle it separately, we could create JS::CompileOption off main thread.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1840839 - Add xpc::SetPrefableCompileOptions and move related prefs to StaticPrefs. r?mccr8!

Depends on D182458

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc3e4979b00e
Add xpc::SetPrefableCompileOptions and move related prefs to StaticPrefs. r=mccr8

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/fc3e4979b00e

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Bug 1840839, bug 1841016 and bug 1840996 have been backed out for wasm crashes, e.g. bp-6f01e03f-96f8-4d44-ae8b-c55a50230707.

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/511a6a347d49
Backed out 2 changesets (bug 1840839, bug 1841016) for causing wasm crashes. a=backout

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/effe2e14391b
Add xpc::SetPrefableCompileOptions and move related prefs to StaticPrefs. r=mccr8

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/effe2e14391b