1840843 - `TypeError: can't access property "startsWith", key is undefined` error in the browser console when opening the new migration window with certain browsers profiles as default

Status: VERIFIED FIXED

(Firefox :: Migration, defect)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: Screen Recording 2023-06-28 at 16.15.45.mov

Found in

• 116.0a1 (2023-06-28)

Affected versions

• 116.0a1 (2023-06-28)

Tested platforms

• Affected platforms: Windows 10x64, macOS 12
• Unaffected platforms: Ubuntu 22.04

Preconditions

• browser.migrate.chrome.extensions.enabled: true
• (maybe?) chrome profile with lots of data (passwords, extensions, history, bookmarks)

Steps to reproduce

1. Open migration window and observe the browser console.

Expected result

• No errors are displayed.

Actual result

• TypeError: can't access property "startsWith", key is undefined _getLocaleString resource:///modules/ChromeMigrationUtils.sys.mjs:146 getExtensionInformation resource:///modules/ChromeMigrationUtils.sys.mjs:110 ChromeMigrationUtils.sys.mjs:127:15 getExtensionInformation resource:///modules/ChromeMigrationUtils.sys.mjs:127 errors are displayed.

Regression range

• Mozregression points at https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=693d34c8447d4730b61eaad4858422001bdb1a7e&tochange=b865b19797f1adb2019d2845b4ad65c34869a433 pushlog on affected machines.

Additional notes

• Attached a screen recording.
• Note that this issue is occurring only on a Windows 10x64 and macOS 12 machine. I can’t reproduce it on Ubuntu 22 or on other Windows 10x64 machine.
• This also happens when the default browser is Chrome when opening the new migration window.
• This issue occurs once after a Firefox startup. The issue occurs again only after a Firefox restart or close/reopen.
• I am not aware of any functionality issues for this error.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:atrif, could you try to find a regression range using for example mozregression?

Comment 2

[William Durand [:willdurand]]

The bug is caused by the extension not having a description in its manifest.json file, see: https://robwu.nl/crxviewer/?crx=https%3A%2F%2Fchrome.google.com%2Fwebstore%2Fdetail%2Fi-dont-care-about-cookies%2Ffihnjjcciajhdojfnbdddfaoknhalnja%2F

The name is required but the description is not so we should account for that.

Comment 3

[William Durand [:willdurand]]

I don't think this is a regression since it's a new feature.

Comment 4

[William Durand [:willdurand]]

Attachment: Bug 1840843 - Handle Chrome extensions without a description in their manifest. r?mconley!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff1fb4487754
Handle Chrome extensions without a description in their manifest. r=mconley

Comment 6

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/ff1fb4487754

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Based on comment #0, this bug contains a bisection range found by mozregression. However, the Regressed by field is still not filled.

:willdurand, if possible, could you fill the Regressed by field?

For more information, please visit BugBot documentation.

Comment 8

[William Durand [:willdurand]]

I don't think that counts as a regression since this is a new feature.

Comment 9

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 116.0a1 (2023-06-29) on Windows 10x64, macOS 12 and Ubuntu 22.04. I no longer see the error mentioned in the description.
However, an invalid manifest log is displayed on all systems after opening the Migration Window for the first time. Please let me know if this isn't expected and if we should file something against it.

Comment 10

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: image.png

This is the log.

Comment 11

[William Durand [:willdurand]]

That debug log statement is indeed expected, thanks!