Closed Bug 1840850 Opened 11 months ago Closed 5 months ago

Upgrade NodeJS to appropriate versions

Categories

(Firefox Build System :: Toolchains, task)

Product:
Firefox Build System
Component:
Toolchains
Type:
task

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1875239

People

(Reporter: standard8, Assigned: standard8)

References

(Depends on 1 open bug)

Details

User Story

How to test locally:

- Apply patch from Phabricator (attachment link in this bug)
- Execute `MOZ_SCM_LEVEL=1 mach bootstrap` to get the Node 12 executables from the try servers
- `mach build`, `mach lint -l eslint`, `mach lint -l eslint --fix` with dirty tree (ie prettier),  etc.

+++ This bug was initially created as a clone of Bug #1762571 +++

Similar to previous upgrades, this is a regular update our NodeJS versions. NodeJS 12 has been unsupported for more than a year now. NodeJS 14 has reached EOL, NodeJS 16 hits end of life in September.

We should review what we're currently using and upgrade as appropriate. If we don't upgrade some of the major versions, we should at least make sure we are on the latest minor version of each.

Rough plan, looking at the Node release plan and assuming we don't hit any issues in testing:

  • NodeJS 12 has been obsolete for more than a year now, so upgrade to latest of 14 for build.
  • For tests upgrade from 16 to 18.
  • On ESR, upgrade testing from 16 to 18. Do not upgrade build, except making sure it is the latest release of the branch.

The upgrade on ESR is to try and reduce potential issues for running lint & tests across branches, which have been making uplifting patches harder for release management.

Depends on: 1842167

Sounds reasonable to me.

Depends on: 1846951

I found a few issues upgrading tests to Node 18 that need looking at, in the meantime I've filed bug 1846951 so that the build system part can be updated from Node 12 to Node 14.

No longer blocks: 1744958

I'm closing this bug out in favour of bug 1846951 and the new bug I've just filed for updating node for tests bug 1875239 - they individually have specific discussions about the requirements.

Status: NEW → RESOLVED
Closed: 5 months ago
Duplicate of bug: 1875239
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.