Open Bug 1840873 Opened 2 years ago Updated 2 years ago

Clean up fake exit frames

Categories

(Core :: JavaScript Engine: JIT, task, P3)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
task

Tracking

()

People

(Reporter: jandem, Unassigned)

References

(Blocks 1 open bug)

Details

Iain noticed that we usually call enterFakeExitFrame when we construct an exit frame. This pushes an ExitFrameType enum value. We also have enterExitFrame that pushes a VMFunctionData*.

This can probably be simplified. Maybe have just one enterExitFrame that takes a Variant<ExitFrameType, VMFunctionData*> or something. Or at least get rid of the word "fake" since these are common and real exit frame types.

Blocks: sm-jits
Severity: -- → S3
Priority: -- → P3

"PERF" key word?

You need to log in before you can comment on or make changes to this bug.