1840930 - Allow API responses to be returned if schema validation fails

Status: RESOLVED DUPLICATE of bug 1840678

(Firefox Graveyard :: Shopping, task, P1)

Description

[❌ PTO, back 8/31 ❌ Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

The initial toolkit commit throws away the API response if validation fails, but this will probably happen pretty often in the MVP development period. Let's instead be permissive, logging an error but otherwise attempting to return whatever we got back from the API fetch.

Comment 1

[❌ PTO, back 8/31 ❌ Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Bug 1840930 - Allow API responses to be returned if schema validation fails. r?fchasen

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f589713e266
Allow API responses to be returned if schema validation fails. r=fchasen

Comment 3

[Cosmin Sabou [:CosminS]]

Backed out for xpcshell failures on test_product.js

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=3f589713e266401f6f89f8547d79109824e55ec7&selectedTaskRun=Hwo3HglYRW2KOCyP3iMzgg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=421100887&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/c0d3d8606d296a2f62b90cc11f8fb506f12f2b3d

Comment 4

[❌ PTO, back 8/31 ❌ Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

sorry for breaking stuff during code freeze! I thought I canceled this on Lando before it made its way to autoland :-\

Comment 5

[Cosmin Sabou [:CosminS]]

No worries Jared, if you fix it and still want it in 116 you can give it another go.

Comment 6

[❌ PTO, back 8/31 ❌ Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

unassigning myself, as :fchasen is going to fix this in another patch he's working on.

Comment 7

[❌ PTO, back 8/31 ❌ Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

This was closed by the patch for bug 1840678