1841167 - SeaMonkey Branding Cleanup

Status: RESOLVED FIXED

(SeaMonkey :: General, enhancement)

Description

[Frank-Rainer Grahl (:frg)]

We still have a few wrong trademark strings in our code which need to be switched to SeaMonkey e.V.

The default bookmarks also have a Mozilla related item in. Since we are no longer a Mozilla project we should not give the impression that there is still a connection between us and them. Further cleanup on the Website needed but lets start with the code.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1841167-branding-25318.patch

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: Wrong legal information
Testing completed (on m-c, etc.): 2.53.18b1 pre
Risk to taking this patch (and alternatives if risky): trivial changes.
String changes made by this patch: see bookmarks.inc

Strings in bookmarks.inc seem not to be picked up for translation so define a dummy file additionalValues.properties in branding.

Comment 2

[Ian Neal]

(In reply to Frank-Rainer Grahl (:frg) from comment #1)

Created attachment 9341824 [details] [diff] [review]
1841167-branding-25318.patch

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: Wrong legal information
Testing completed (on m-c, etc.): 2.53.18b1 pre
Risk to taking this patch (and alternatives if risky): trivial changes.
String changes made by this patch: see bookmarks.inc

Strings in bookmarks.inc seem not to be picked up for translation so define a dummy file additionalValues.properties in branding.

When I do mach build installers-<locale> it seems to pick up bookmarks.inc fine for me

Comment 3

[Frank-Rainer Grahl (:frg)]

I am pretty much sure a missing translation in bookmarks.inc will not show up in Pontoon but may be wrong. If everything else is ok and you r/a+ I will split this part and not check it in. If it does not show up then I will push it separately for later removal after Pontoon access is gone.

Comment 4

[Frank-Rainer Grahl (:frg)]

Attachment: 1841167-branding-1_1-25318.patch

Seems Pontoon is picking up bookmarks.inc after all.

Comment 5

[Ian Neal]

Comment on attachment 9342050 [details] [diff] [review]
1841167-branding-1_1-25318.patch

[Triage Comment]
LGTM r/a=me

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/084d5ce463ff
Clean up branding files. r=IanN

Comment 7

[Frank-Rainer Grahl (:frg)]

Attachment: 1841167-2-fixbranding-25318.patch

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: Wrong vendor information in Windows programm install details.
Testing completed (on m-c, etc.): 2.53.19b1 pre
Risk to taking this patch (and alternatives if risky): trivial.
String changes made by this patch: hardcoded branding strings only.

Comment 8

[Frank-Rainer Grahl (:frg)]

Attachment: Windows install details

Comment 9

[Ian Neal]

Comment on attachment 9360895 [details] [diff] [review]
1841167-2-fixbranding-25318.patch

Review of attachment 9360895 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM r/a=me

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c7d927f15aee
Change company info and url in nsis installer. r=IanN

Comment 11

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/3a589ab0888a6bcd214f3aeda3fa39b802e5fb8e
Clean up branding files. r=IanN a=IanN
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/ec0f9852f55685b45615c1d415b73668a4fa9860
Change company info and urls in nsis installer. r=IanN a=IanN