1841238 - 2.72% compiler_metrics num_static_constructors (Linux) regression on Fri June 23 2023

Status: RESOLVED WONTFIX

(Core :: Widget: Gtk, defect)

Description

[Alex Finder]

Perfherder has detected a build_metrics performance regression from push ba9712fc3d709f77a7ccd71121c00a1e261e3184. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
3%	compiler_metrics num_static_constructors	linux64	x11	147.00 -> 151.00

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) may be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1839599

Comment 2

[Martin Stránský [:stransky] (ni? me)]

I'd say it's because we enabled HW acceleration and dmabuf on X11-only builds (it was enabled on Wayland only before). Ho exactly is the build configured? Does it support Wayland or not?

If that's X11 only code we enabled bunch of new features here and dmabuf setup may use static init. Do we know how many num_static_constructors use different linux builds? Right now all Linux builds have the same num_static_constructors num.

Comment 3

[Pascal Chevrel:pascalc]

Alex, could you answer some of Martin's questions? Thanks

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1839599

Comment 5

[Cieara Meador [:cmkm]]

:sparky Hello! Just wondering if you have any context for this issue and whether we should expect a fix for 116 beta? Thank you :)

Comment 6

[Greg Mierzwinski [:sparky]]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #2)

I'd say it's because we enabled HW acceleration and dmabuf on X11-only builds (it was enabled on Wayland only before). Ho exactly is the build configured? Does it support Wayland or not?

I think :ahochheiden can help answer how the build is configured, it's this one on treeherder: https://treeherder.mozilla.org/jobs?repo=autoland&revision=ba9712fc3d709f77a7ccd71121c00a1e261e3184&searchStr=build-linux64-x11%2Fopt

Comment 7

[Mike Hommey [:glandium]]

Normal builds have X11+wayland, X11-only builds have... X11 and no wayland, as per their name. The normal builds have 154 static constructors per https://treeherder.mozilla.org/perfherder/graphs?series=autoland,1468481,1,2&selected=1468481,1725838855

Comment 8

[Dianna Smith [:diannaS]]

adding NI since previous questions were answered

Comment 9

[Martin Stránský [:stransky] (ni? me)]

(In reply to Mike Hommey [:glandium] from comment #7)

Normal builds have X11+wayland, X11-only builds have... X11 and no wayland, as per their name. The normal builds have 154 static constructors per https://treeherder.mozilla.org/perfherder/graphs?series=autoland,1468481,1,2&selected=1468481,1725838855

I guess it's okay then. It's expected change due to newly enabled features and aligns with our standard wayland+x11 setup where full feature set is built already.