1841292 - WPT failures in css/css-transforms/transform-2d-getComputedStyle-001.html

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Thomas Wisniewski [:twisniewski]]

It seems that we're not passing these because we are expected to return transform:none, not the actual transform:matrix() value, when the element has display:none.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:boris, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Boris Chiou [:boris]]

I may take a look at this.

Comment 3

[Boris Chiou [:boris]]

We probably need to add a special check in https://searchfox.org/mozilla-central/rev/d2a61d9c63beb3ac4b134767e43a7a8c1b91d5cd/layout/style/nsComputedDOMStyle.cpp#2327 for display:none.

Comment 4

[Boris Chiou [:boris]]

Attachment: Bug 1841292 - getComputedStyle().transform returns none if the element is in the display:none subtree.

Comment 5

[Boris Chiou [:boris]]

Attachment: Bug 1841292 - A minor refactoring to return a simple nsROCSSPrimitiveValue string.

Reuse nsROCSSPrimitiveValue(const nsACString&) in more places.

No behavior change.

Comment 6

[Boris Chiou [:boris]]

Attachment: Bug 1841292 - Update wpt for the serialization of transform when display is none.

The spec doesn't mention anything about displen:none, so per the spec,
we should use either matrix() syntax or just make computed value be the
resolved value. Blink and Webkit return none, so for now we accept both
cases. Once the spec issue gets resolved, we can update there.

https://drafts.csswg.org/css-transforms-2/#serialization-of-the-computed-value

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80d5d57caeb9
Update wpt for the serialization of transform when display is none. r=emilio

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/41603 for changes under testing/web-platform/tests

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/80d5d57caeb9

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot