1841296 - Firefox fails WPT css/css-grid/subgrid/contribution-size-flex-tracks-001.html

Status: RESOLVED FIXED

(Core :: Layout: Grid, defect)

Description

[Thomas Wisniewski [:twisniewski]]

wpt.fyi:
https://wpt.fyi/results/css/css-grid/subgrid/contribution-size-flex-tracks-001.html

Comment 1

[Daniel Holbert [:dholbert]]

As in bug 1833486, it looks like this test is just expecting certain properties to be ignored on subgrids as the spec requires (width and height in this case)

The green subgrid here has width:50px; height:50px which we are dutifully honoring; but if I remove those (or if we ignore those as it looks like we should), then we fill the grid and match the expected rendering.

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

The patch in bug 1833486 fixed this test, too.

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: Bug 1841296 - Implement stretch for subgrids in the subgridded axis. r?dholbert

This implements https://drafts.csswg.org/css-grid/#subgrid-box-alignment

Comment 4

[Daniel Holbert [:dholbert]]

(In reply to Ting-Yu Lin [:TYLin] (UTC-8) from comment #2)

The patch in bug 1833486 fixed this test, too.

That patch lives over here now. Let's mark bug 1833486 as depends-on this one, since this patch gets us nearly to passing that test, modulo the baseline issue discussed in phabricator

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20d9f6b14ee3
Implement stretch for subgrids in the subgridded axis. r=dholbert

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/20d9f6b14ee3