1841297 - Firefox fails WPT css/css-grid/subgrid/grid-gap-011.html

Status: RESOLVED FIXED

(Core :: Layout: Grid, defect)

Description

[Thomas Wisniewski [:twisniewski]]

wpt.fyi:
https://wpt.fyi/results/css/css-grid/subgrid/grid-gap-011.html

Comment 1

[Daniel Holbert [:dholbert]]

Live link to test:
http://wpt.live/css/css-grid/subgrid/grid-gap-011.html

We render two separate blue squares. The right one is at the same position as other browsers (offsetLeft = 283). The left one we render further leftwards than other browsers (offsetLeft=133)

The test is testing "subgrids with column gap larger than the track size", per its title. We seem to be interoperable up until the gap reaches the track size, and then with larger values, we start moving the first grid item leftwards, which is not what the test expects.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1841297 - Fix subgrid position when the gap is larger than track size.

grid-gap-012.html is adapted from grid-gap-011.html, but with subgrid's gap
changed to 250px. Both Chrome and Safari pass the test. It coverts the position
fix for lastTrack.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0a378b117e0
Fix subgrid position when the gap is larger than track size. r=dholbert

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43775 for changes under testing/web-platform/tests

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d0a378b117e0

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged