1841330 - WPT failure in css/css-grid/parsing/grid-area-computed.html

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Thomas Wisniewski [:twisniewski]]

We are presently failing just one test for:
https://wpt.fyi/results/css/css-grid/parsing/grid-area-computed.html

Property grid-column-start value 'span 1 i'
assert_equals: expected "span i" but got "span 1 i"

FWIW, WebKit seem to have fixed it by fixing this bug: https://bugs.webkit.org/show_bug.cgi?id=226694

Comment 1

[Boris Chiou [:boris]]

Attachment: Bug 1841330 - Fix the serialization of <grid-line> when using span.

When using span for grid-area, the default line number is 1. So we
omit it if possible, per shortest serialization principle.

https://drafts.csswg.org/css-grid/#grid-placement-span-int

Comment 2

[Boris Chiou [:boris]]

Attachment: Bug 1841330 - Use CustomIdent for GridLine.

So we can avoid calling clone() in to_css().

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e26dc4e7f443
Fix the serialization of <grid-line> when using span. r=emilio
https://hg.mozilla.org/integration/autoland/rev/3b45d04f6865
Use CustomIdent for GridLine. r=emilio

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43219 for changes under testing/web-platform/tests

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/e26dc4e7f443
https://hg.mozilla.org/mozilla-central/rev/3b45d04f6865

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot