1841354 - The feedback acknowledgment remains when the row is reused

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Drew Willcoxon :adw]

The feedback acknowledgment can stick around when its row is reused for a different type of result. This hasn't been a problem until now, with Pocket suggestions, because before it's only been used for best matches, and best matches are practically never reused. I think we should just always remove it.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1841354 - Always remove the feedback acknowledgment when a row is updated.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b978ed538739
Always remove the feedback acknowledgment when a row is updated. r=dao

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/b978ed538739

Comment 4

[Drew Willcoxon :adw]

Comment on attachment 9341998 [details]
Bug 1841354 - Always remove the feedback acknowledgment when a row is updated.

Beta/Release Uplift Approval Request

• User impact if declined: This bug is necessary for the Pocket suggestions feature we intend to ship as an experiment in 116.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Two-line patch that only affects a small message shown in the urlbar UI. Only relevant to features that are not enabled by default. Covered by tests.
• String changes made/needed:
• Is Android affected?: No

Comment 5

[Dianna Smith [:diannaS]]

Comment on attachment 9341998 [details]
Bug 1841354 - Always remove the feedback acknowledgment when a row is updated.

Approved for 116.0b2

Comment 6

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7edb7e04f45d