1841366 - Add a flowId to existing Translations telemetry events

Status: RESOLVED FIXED

(Firefox :: Translations, enhancement)

Description

[Erik Nordin [:nordzilla]]

Moving forward we will be using a flowId to associate related translations events within the same logical user session.

This patch will add a flowId to all existing Translations telemetry events.

Comment 1

[Erik Nordin [:nordzilla]]

Attachment: Bug 1841366 - Rename TestTranslationsTelemetry variables r=gregtatum!

Renames some variables in the translations telemetry tests
to make the code more readable.

Comment 2

[Erik Nordin [:nordzilla]]

Attachment: Bug 1841366 - Add Translations telemetry flowId pref r=gregtatum!

Adds a pref for a flowId to utilize in Translations telemetry.
This id will tie together related events within a logical session
of translations.

Depends on D182610

Comment 3

[Erik Nordin [:nordzilla]]

Attachment: Bug 1841366 - Add flowId to existing Translations telemetry events r=gregtatum!

Instruments all pre-existing Translations telemetry events
to utilize the flowId.

Depends on D182611

Comment 4

[Erik Nordin [:nordzilla]]

Attachment: Bug 1841366 - Test flowId in Translations telemetry r=gregtatum!

Adds test infrastructure and test cases to assert that the flowId
is being tracked correctly in Translations telemetry events.

Depends on D182612

Comment 5

[Erik Nordin [:nordzilla]]

Attachment: WIP: Bug 1841366 - FlowId on TranslationsParent WIP

Depends on D182613

Comment 6

[Erik Nordin [:nordzilla]]

Attachment: WIP: Bug 1841366 - Unify TranslationsTelemetry WIP

Depends on D182613

Comment 7

[Erik Nordin [:nordzilla]]

Attachment: Bug 1841366 - Unify TranslationsTelemetry in toolkit r=gregtatum!

Unifies the TranslationsTelemetry implementations into a single file
using only one metrics.yaml file as well

Depends on D182610

Comment 8

[Erik Nordin [:nordzilla]]

Attachment: Bug 1841366 - Utilize flowId in existing Translations telemetry r=gregtatum!

Instruments all pre-existing Translations telemetry events
to utilize the flowId event extra key.

Depends on D183044

Comment 9

[Erik Nordin [:nordzilla]]

Attachment: data-review-request

Comment 10

[Erik Nordin [:nordzilla]]

chutten,

All of these metrics were ones that I added in the last cycle.

This request is to add a flow_id as an extra key to the events.

Comment 11

[Chris H-C :chutten]

Comment on attachment 9343101 [details]
data-review-request

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection can be controlled through the product's preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in Firefox 122.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No. (The introduction of a local uuid for sessionization isn't an "identifier" as meant for this process)

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb07de1d0a14
Rename TestTranslationsTelemetry variables r=gregtatum
https://hg.mozilla.org/integration/autoland/rev/cbaeb41e063a
Unify TranslationsTelemetry in toolkit r=gregtatum
https://hg.mozilla.org/integration/autoland/rev/e2e5864f1493
Utilize flowId in existing Translations telemetry r=gregtatum
https://hg.mozilla.org/integration/autoland/rev/2dc0ffebfdee
Test flowId in Translations telemetry r=gregtatum

Comment 13

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/eb07de1d0a14
https://hg.mozilla.org/mozilla-central/rev/cbaeb41e063a
https://hg.mozilla.org/mozilla-central/rev/e2e5864f1493
https://hg.mozilla.org/mozilla-central/rev/2dc0ffebfdee