1841409 - The Feedback menu button sometimes isn't shown

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Drew Willcoxon :adw]

When a row is reused, the new result has showFeedbackMenu, and the old result didn't, the row won't show the Feedback menu button. We need to create new row content in that case.

This hasn't been a problem before because the Feedback button was only shown in best matches, which practically are never reused. Pocket non-best-match rows will show the button, which is how I noticed this.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1841409 - Create new row content as necessary to make sure the Feedback button is shown.

Depends on D182537

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5cf32b0ba18a
Create new row content as necessary to make sure the Feedback button is shown. r=dao

Comment 3

[Drew Willcoxon :adw]

STR for QA:

1. Set browser.urlbar.pocket.featureGate = true to enable Pocket suggestions
2. Type "breakfast" and verify a low confidence (non-top-pick) Pocket suggestion appears
3. Verify the Feedback button appears in the suggestion
4. Modify your search string several times so the suggestion goes away and reappears (e.g., backspace over the last few characters, type a few extra characters, etc.) and verify the Feedback button always appears in the suggestion

Comment 4

[Drew Willcoxon :adw]

Comment on attachment 9342040 [details]
Bug 1841409 - Create new row content as necessary to make sure the Feedback button is shown.

Beta/Release Uplift Approval Request

• User impact if declined: This bug is necessary for the Pocket suggestions feature we intend to ship as an experiment in 116.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Please see STR in previous comment
• List of other uplifts needed: The following bugs must be uplifted first: 1841553, Bug 1841408
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very small change that only affects urlbar suggestions with the "Feedback" button in them, and those suggestions are disabled by default. Covered by tests.
• String changes made/needed:
• Is Android affected?: No

Comment 5

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures.

• Backout link
• Push with failures
• Failure Log
• Failure line: PROCESS-CRASH | MOZ_ASSERT(mInitialZoomConstraints->mPresShellID == aPresShellId) [@ libxul.so + 0x00000000048f60f4] | toolkit/components/extensions/test/mochitest/mochitest.ini:toolkit/components/extensions/test/mochitest/mochitest-common.ini

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c1ffa30508d
Create new row content as necessary to make sure the Feedback button is shown. r=dao

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/4c1ffa30508d

Comment 8

[Dianna Smith [:diannaS]]

Comment on attachment 9342040 [details]
Bug 1841409 - Create new row content as necessary to make sure the Feedback button is shown.

Approved for 116.0b2

Comment 9

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6cb871ef3ebb

Comment 10

[Carmen Fat [:cfat] - Ecosystem QA]

I have verified this issue on the latest Firefox Nightly 117.0a1 (Build ID: 20230706092222), on Windows 10 x64, macOS 13.4.1, and Ubuntu 20.04 x64.

• The "Cat Cora" Pocket suggestion appears at the bottom of the Urlbar panel after typing the complete string (“breakfast”). The label displayed above the suggestion is "Firefox Suggest".
• The “Feedback” button is displayed on the right side of the suggestion.
• The “Feedback” button remains displayed when deleting one or more characters from the keyword.
• The “Feedback” button remains displayed when adding one or more characters of a full keyword (“breakfast casserole recipes”)
• The “Feedback” button is displayed again when typing a keyword after previously clicking the Pocket suggestion.
• The “Feedback” button is displayed again if re-focusing the Urlbar when a keyword is already typed inside the Address Bar.

Comment 11

[Carmen Fat [:cfat] - Ecosystem QA]

I have verified this issue on the latest Firefox Beta 116.0b2 (Build ID: 20230706193912), on Windows 10 x64, macOS 13.4.1, and Ubuntu 20.04 x64.

• The "Cat Cora" Pocket suggestion appears at the bottom of the Urlbar panel after typing the complete string (“breakfast”). The label displayed above the suggestion is "Firefox Suggest".
• The “Feedback” button is displayed on the right side of the suggestion.
• The “Feedback” button remains displayed when deleting one or more characters from the keyword.
• The “Feedback” button remains displayed when adding one or more characters of a full keyword (“breakfast casserole recipes”)
• The “Feedback” button is displayed again when typing a keyword after previously clicking the Pocket suggestion.
• The “Feedback” button is displayed again if re-focusing the Urlbar when a keyword is already typed inside the Address Bar.