1841432 - High freq /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-source-media-env-change.html | the <source> media attribute: no reaction to environment change - assert_equals: afterEnvChange expected "#a"

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Treeherder Bug Filer]

Filed by: ctuns [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=421289635&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/bQIE0FJUTJOnvJjwRFCPyQ/runs/0/artifacts/public/logs/live_backing.log

---

[task 2023-07-02T11:37:40.294Z] 11:37:40     INFO - TEST-START | /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-source-media-env-change.html
[task 2023-07-02T11:37:40.311Z] 11:37:40     INFO - Closing window fc3e2b63-d093-4c19-a9f7-ccf08f8d6ab1
[task 2023-07-02T11:37:40.717Z] 11:37:40     INFO - 
[task 2023-07-02T11:37:40.717Z] 11:37:40     INFO - TEST-UNEXPECTED-PASS | /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-source-media-env-change.html | the <source> media attribute: no reaction to environment change - expected FAIL
[task 2023-07-02T11:37:40.717Z] 11:37:40     INFO - TEST-INFO | expected FAIL
[task 2023-07-02T11:37:40.728Z] 11:37:40     INFO - TEST-OK | /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-source-media-env-change.html | took 423ms
[task 2023-07-02T11:37:40.730Z] 11:37:40     INFO - PID 7188 | 1688297860729	Marionette	INFO	Stopped listening on port 53198
[task 2023-07-02T11:37:41.392Z] 11:37:41     INFO - PID 7188 | [Parent 1708, IPC I/O Parent] WARNING: DuplicateHandle failed for handle 0 in TransferHandles: file /builds/worker/checkouts/gecko/ipc/chromium/src/chrome/common/ipc_channel_win.cc:621
[task 2023-07-02T11:37:41.402Z] 11:37:41     INFO - PID 7188 | [GPU 7632, IPC I/O Child] WARNING: pipe error: 232: file /builds/worker/checkouts/gecko/ipc/chromium/src/chrome/common/ipc_channel_win.cc:443
[task 2023-07-02T11:37:41.413Z] 11:37:41     INFO - PID 7188 | [Parent 1708, IPC I/O Parent] WARNING: DuplicateHandle failed for handle 0 in TransferHandles: file /builds/worker/checkouts/gecko/ipc/chromium/src/chrome/common/ipc_channel_win.cc:621
[task 2023-07-02T11:37:41.413Z] 11:37:41     INFO - PID 7188 | [GPU 7632, IPC I/O Child] WARNING: pipe error: 232: file /builds/worker/checkouts/gecko/ipc/chromium/src/chrome/common/ipc_channel_win.cc:443
[task 2023-07-02T11:37:41.413Z] 11:37:41     INFO - PID 7188 | console.error: ({})
[task 2023-07-02T11:37:41.424Z] 11:37:41     INFO - PID 7188 | [Parent 1708, IPC I/O Parent] WARNING: DuplicateHandle failed for handle 0 in TransferHandles: file /builds/worker/checkouts/gecko/ipc/chromium/src/chrome/common/ipc_channel_win.cc:621
[task 2023-07-02T11:37:41.424Z] 11:37:41     INFO - PID 7188 | [GPU 7632, IPC I/O Child] WARNING: pipe error: 232: file /builds/worker/checkouts/gecko/ipc/chromium/src/chrome/common/ipc_channel_win.cc:443
[task 2023-07-02T11:37:41.424Z] 11:37:41     INFO - PID 7188 | [Parent 1708, IPC I/O Parent] WARNING: DuplicateHandle failed for handle 0 in TransferHandles: file /builds/worker/checkouts/gecko/ipc/chromium/src/chrome/common/ipc_channel_win.cc:621
[task 2023-07-02T11:37:41.424Z] 11:37:41     INFO - PID 7188 | [GPU 7632, IPC I/O Child] WARNING: pipe error: 232: file /builds/worker/checkouts/gecko/ipc/chromium/src/chrome/common/ipc_channel_win.cc:443
[task 2023-07-02T11:37:41.424Z] 11:37:41     INFO - PID 7188 | [Parent 1708, IPC I/O Parent] WARNING: DuplicateHandle failed for handle 0 in TransferHandles: file /builds/worker/checkouts/gecko/ipc/chromium/src/chrome/common/ipc_channel_win.cc:621
[task 2023-07-02T11:37:41.424Z] 11:37:41     INFO - PID 7188 | [GPU 7632, IPC I/O Child] WARNING: pipe error: 232: file /builds/worker/checkouts/gecko/ipc/chromium/src/chrome/common/ipc_channel_win.cc:443
[task 2023-07-02T11:37:41.705Z] 11:37:41     INFO - Browser exited with return code 0
[task 2023-07-02T11:37:41.707Z] 11:37:41     INFO - Closing logging queue
[task 2023-07-02T11:37:41.708Z] 11:37:41     INFO - queue closed
[task 2023-07-02T11:37:41.830Z] 11:37:41     INFO - Application command: Z:\task_168829301422369\build\application\firefox\firefox.exe -marionette about:blank --wait-for-browser -profile C:\Users\task_168829301422369\AppData\Local\Temp\tmpa5uxdw3f
[task 2023-07-02T11:37:41.840Z] 11:37:41     INFO - PID 5796 | 1688297757807	Marionette	INFO	Marionette enabled
[task 2023-07-02T11:37:41.840Z] 11:37:41     INFO - PID 5796 | 1688297757880	Marionette	INFO	Listening on port 53210
[task 2023-07-02T11:37:41.841Z] 11:37:41     INFO - PID 5796 | JavaScript error: resource://gre/modules/XULStore.sys.mjs, line 60: Error: Can't find profile directory.
[task 2023-07-02T11:37:41.842Z] 11:37:41     INFO - PID 5796 | console.error: (new Error("Unexpected content-type \"text/plain;charset=US-ASCII\"", "resource://services-settings/Utils.sys.mjs", 399))
[task 2023-07-02T11:37:41.842Z] 11:37:41     INFO - PID 5796 | [Parent 7808, IPC I/O Parent] WARNING: DuplicateHandle failed for handle 0 in TransferHandles: file /builds/worker/checkouts/gecko/ipc/chromium/src/chrome/common/ipc_channel_win.cc:621
[task 2023-07-02T11:37:41.843Z] 11:37:41     INFO - PID 5796 | [GPU 9032, IPC I/O Child] WARNING: pipe error: 232: file /builds/worker/checkouts/gecko/ipc/chromium/src/chrome/common/ipc_channel_win.cc:443
[task 2023-07-02T11:37:41.844Z] 11:37:41     INFO - PID 5796 | console.error: (new Error("Unexpected content-type \"text/plain;charset=US-ASCII\"", "resource://services-settings/Utils.sys.mjs", 399))
[task 2023-07-02T11:37:41.844Z] 11:37:41     INFO - PID 5796 | console.error: (new Error("Unexpected content-type \"text/plain;charset=US-ASCII\"", "resource://services-settings/Utils.sys.mjs", 399))
[task 2023-07-02T11:37:41.845Z] 11:37:41     INFO - PID 5796 | console.error: (new Error("Unexpected content-type \"text/plain;charset=US-ASCII\"", "resource://services-settings/Utils.sys.mjs", 399))
[task 2023-07-02T11:37:41.846Z] 11:37:41     INFO - PID 5796 | console.error: (new Error("Polling for changes failed: Unexpected content-type \"text/plain;charset=US-ASCII\".", "resource://services-settings/remote-settings.sys.mjs", 324))
[task 2023-07-02T11:37:41.847Z] 11:37:41     INFO - Starting runner
[task 2023-07-02T11:37:43.133Z] 11:37:43     INFO - TEST-START | /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-source-media.html

Comment 1

[Intermittent Failures Robot]

1 failures in 3594 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1

Platform and build breakdown:

• windows11-32-2009-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1841432&startday=2023-06-26&endday=2023-07-02&tree=all

Comment 2

[Intermittent Failures Robot]

16 failures in 700 pushes (0.023 failures/push) were associated with this bug yesterday.

Repository breakdown:

• try: 2
• autoland: 7
• mozilla-central: 7

Platform and build breakdown:

• windows11-32-2009-qr: 1
  • debug: 1
• android-em-7-0-x86_64-qr: 3
  • debug: 3
• linux1804-64-qr: 4
  • opt: 3
  • debug: 1
• linux1804-64-asan-qr: 2
  • opt: 2
• linux1804-64-shippable-qr: 4
  • opt: 4
• macosx1015-64-qr: 1
  • debug: 1
• linux1804-64-ccov-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1841432&startday=2023-10-03&endday=2023-10-03&tree=all

Comment 3

[Cristina Horotan [:chorotan]]

Done retriggers and backfills up to here

Scott, it seems that from your push it started to frequently fail, can you please take a look?

Thanks

Comment 4

[Paul Adenot (:padenot)]

Maybe the layout flush isn't enough and we need the test to be tighter.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1836128

Comment 6

[Scott Jehl]

@padenot do you think this alternative test setup might be worth considering? Is it easy to test if it makes a difference in the environments where the test is flakey? https://phabricator.services.mozilla.com/D189416#6278406

Comment 7

[Paul Adenot (:padenot)]

Yeah, just attach a patch modifying the file in this bug and I can retrigger a bunch to make sure it's solid.

Comment 8

[Scott Jehl]

@padenot looks like it wants me to do a full rebuild to test this change, which I recall taking quite a while on my machine. I'll add a patch here in case you are able to test it sooner, as it looks correct to my eye at least, but I will have to leave a build running for a bit before I can test it myself locally

Comment 9

[Paul Adenot (:padenot)]

Since you don't modify any C++, you can run the test in a regular nightly Firefox.

Comment 10

[Scott Jehl]

Thanks! Okay, that helped me debug this.

So I noticed the flakiness locally as well, which is good. I updated to a promise.all pattern, which does seem to make the test series more reliable.

However, I noticed that there seems to be a problem in the tests' use of the delayed-broken-video.py video file, which fails as a supported source format and seems to cause Firefox to select to the next source element (which also fails, but that ends up as the currentSrc in the end regardless). Does that sound like expected behavior?

I can confirm that if I use the promise pattern along with a path to a playable video ("/media-source/mp4/test.mp4" is one I found), then the tests are running reliably, passing reliably in both Nightly and Safari while expectedly failing the third test in unsupported browsers like Firefox Stable and Chrome. Is it okay to use that mp4 video path instead of the broken-video.py?

I'll attach a patch for that.

Comment 11

[Paul Adenot (:padenot)]

It's probably OK then. There's is a js function that returns a URL to a playable media file but I don't have a link handy.

Comment 12

[Scott Jehl]

Attachment: Bug 1841432 - change test setup to rely on promises that the child iframe will resolve and also use a supported and playable video source so that source selection sticks. r?padenot

Comment 13

[Intermittent Failures Robot]

50 failures in 836 pushes (0.06 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 29
• mozilla-central: 16
• try: 5

Platform and build breakdown:

• linux1804-64-qr: 16
  • opt: 12
  • debug: 4
• linux1804-64-asan-qr: 15
  • opt: 15
• linux1804-64-shippable-qr: 13
  • opt: 13
• android-em-7-0-x86_64-qr: 5
  • debug: 5
• linux1804-64-ccov-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1841432&startday=2023-10-04&endday=2023-10-04&tree=all

Comment 14

[Paul Adenot (:padenot)]

After a number of rettrigers, no failure (was about 6% failure before): https://treeherder.mozilla.org/jobs?repo=try&revision=4200318d069de6e3cb26f8156d8badec660b9e38

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/029a69533eb9
change test setup to rely on promises that the child iframe will resolve and also use a supported and playable  video source so that source selection sticks. r=padenot

Comment 16

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/42361 for changes under testing/web-platform/tests

Comment 17

[Scott Jehl]

Great to hear, @padenot!

Comment 18

[Cristina Horotan [:chorotan]]

Backed out changeset 029a69533eb9 (Bug 1841432) for causing wpt perma failures at resource-selection-source-media-env-change.html

Backout: https://hg.mozilla.org/integration/autoland/rev/6b57dd41fa3e3f9293105e1cce4f0efefa4ee2f6

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=CAeaCqxHTA-nTxWnCv7ciQ.0&searchStr=linux%2C18.04%2Cx64%2Cwebrender%2Copt%2Cweb%2Cplatform%2Ctests%2Cwithout%2Cfission%2Cenabled%2Ctest-linux1804-64-qr%2Fopt-web-platform-tests-nofis%2Cwpt8&revision=029a69533eb91fb8eb33ea3176bef8777cf5516a

Failure log: https://treeherder.mozilla.org/logviewer?job_id=431502949&repo=autoland&lineNumber=3396

Comment 19

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 20

[Intermittent Failures Robot]

50 failures in 754 pushes (0.066 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 37
• mozilla-central: 10
• try: 3

Platform and build breakdown:

• android-em-7-0-x86_64-qr: 3
  • debug: 3
• linux1804-64-qr: 19
  • opt: 12
  • debug: 7
• linux1804-64-asan-qr: 7
  • opt: 7
• linux1804-64-shippable-qr: 9
  • opt: 9
• windows11-64-2009-qr: 3
  • debug: 2
  • opt: 1
• macosx1015-64-qr: 2
  • debug: 1
  • opt: 1
• linux1804-64-ccov-qr: 1
  • opt: 1
• linux1804-64-devedition-qr: 1
  • opt: 1
• windows11-32-2009-qr: 3
  • opt: 2
  • debug: 1
• linux1804-64-tsan-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1841432&startday=2023-10-05&endday=2023-10-05&tree=all

Comment 21

[Paul Adenot (:padenot)]

Ah a race between us landing and the wpt sync bot updating expectations. I'll fix this.

Comment 22

[Paul Adenot (:padenot)]

Attachment: Bug 1841432 - Adjust expectations after fixing resource-selection-source-media-env-change.html

Comment 23

[Paul Adenot (:padenot)]

https://phabricator.services.mozilla.com/D190261

Comment 24

[Scott Jehl]

@pademot did the new patch end up running into problems as well?

Comment 25

[Paul Adenot (:padenot)]

No, we just got unlucky and the wpt-bot merged new expectations' data while we were landing this fix.

Comment 26

[Scott Jehl]

Oh! Good to hear

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c24e7fdc1f3
change test setup to rely on promises that the child iframe will resolve and also use a supported and playable  video source so that source selection sticks. r=padenot
https://hg.mozilla.org/integration/autoland/rev/961131493c60
Adjust expectations after fixing resource-selection-source-media-env-change.html

Comment 28

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/3c24e7fdc1f3
https://hg.mozilla.org/mozilla-central/rev/961131493c60

Comment 29

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 30

[Intermittent Failures Robot]

131 failures in 4018 pushes (0.033 failures/push) were associated with this bug in the last 7 days.

This is the #7 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• try: 16
• autoland: 79
• mozilla-central: 36

Platform and build breakdown:

• windows11-32-2009-qr: 4
  • debug: 2
  • opt: 2
• android-em-7-0-x86_64-qr: 11
  • debug: 11
• linux1804-64-qr: 39
  • opt: 27
  • debug: 12
• linux1804-64-asan-qr: 30
  • opt: 30
• linux1804-64-shippable-qr: 28
  • opt: 28
• macosx1015-64-qr: 4
  • debug: 2
  • opt: 2
• linux1804-64-ccov-qr: 5
  • opt: 5
• windows11-64-2009-qr: 4
  • debug: 3
  • opt: 1
• linux1804-64-devedition-qr: 2
  • opt: 2
• linux1804-64-tsan-qr: 4
  • opt: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1841432&startday=2023-10-02&endday=2023-10-08&tree=all