1841444 - Crash in [@ AsyncShutdownTimeout | AddonManager: Waiting to start provider shutdown. | AddonRepository Background Updater]

Status: ASSIGNED

(Toolkit :: Add-ons Manager, defect, P2)

Description

[alex_mayorga]

Crash report: https://crash-stats.mozilla.org/report/index/f7f419cf-3d3e-4b04-9ec0-eeb380230626

MOZ_CRASH Reason: [Parent 26440, Main Thread] ###!!! ABORT: file resource://gre/modules/addons/AddonRepository.sys.mjs:574

Top 10 frames of crashing thread:

0  xul.dll  AnnotateMozCrashReason  mfbt/Assertions.h:43
0  xul.dll  MOZ_Crash  mfbt/Assertions.h:263
0  xul.dll  Abort  xpcom/base/nsDebugImpl.cpp:513
0  xul.dll  NS_DebugBreak  xpcom/base/nsDebugImpl.cpp:496
1  xul.dll  nsDebugImpl::Abort  xpcom/base/nsDebugImpl.cpp:129
2  xul.dll  XPTC__InvokebyIndex  
3  xul.dll  NS_InvokeByIndex  xpcom/reflect/xptcall/md/win32/xptcinvoke_x86_64.cpp:57
3  xul.dll  CallMethodHelper::Invoke  js/xpconnect/src/XPCWrappedNative.cpp:1627
3  xul.dll  CallMethodHelper::Call  js/xpconnect/src/XPCWrappedNative.cpp:1180
3  xul.dll  XPCWrappedNative::CallMethod  js/xpconnect/src/XPCWrappedNative.cpp:1126

¡Hola y'all!

This is top 17 crash over at
https://crash-stats.mozilla.org/topcrashers/?product=Firefox&version=116.0a1
as of today.

Filing this FWIW.

¡Gracias!
Alex

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The bug is linked to a topcrash signature, which matches the following criteria:

• Top 20 desktop browser crashes on release
• Top 20 desktop browser crashes on beta

For more information, please visit BugBot documentation.

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1841444 - Return earlier from AddonRepository.backgroundUpdateCheck and reject AddonRepository._fetchPaged if application shutdown was already initiated. r?willdurand!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef8fe3a3b9f8
Return earlier from AddonRepository.backgroundUpdateCheck and reject AddonRepository._fetchPaged if application shutdown was already initiated. r=willdurand

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/ef8fe3a3b9f8

Comment 5

[Wayne Mery (:wsmwk)]

Possible to uplift this to esr? This ranks #31 for Thunderbird 115.8.0

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:rpl, maybe it's time to close this bug?
For more information, please visit BugBot documentation.

Comment 7

[Wayne Mery (:wsmwk)]

Still a top ~10 crash for Thunderbird 128esr and 115esr

Comment 8

[Wayne Mery (:wsmwk)]

In reply to Wayne Mery (:wsmwk) from comment #7)

Still a top ~10 crash for Thunderbird 128esr and 115esr

I'm sure this was true when I wrote it. But no longer true now.
There are however other signatures with addon manager https://crash-stats.mozilla.org/search/?proto_signature=~AddonManager&product=Thunderbird&date=%3E%3D2024-11-16T11%3A24%3A00.000Z&date=%3C2025-05-16T11%3A24%3A00.000Z&_facets=signature&_sort=-date&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-signature

Magnus, do we need something specifically adapted to Thunderbird.

I crashed on Windows during shutdown after having done "Check for updates" in the addons manager bp-1fb4b1c5-136d-4800-8fce-ae7e50250513

Comment 9

[Magnus Melin [:mkmelin] (away, back Aug 4)]

I don't have any ideas here.