Closed Bug 1841496 Opened 1 year ago Closed 1 year ago

Copy container units bit when reusing reset properties.

Categories

(Core :: CSS Parsing and Computation, task)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
117 Branch
Tracking Flags:
Tracking Status
firefox117 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

Bug 1841496 - Copy container units bit when reusing reset properties. r=dshin,#style
48 bytes, text/x-phabricator-request
Details | Review
No description provided.

I don't think this changes behavior right now because container units
prevent rule cache sharing here:

https://searchfox.org/mozilla-central/rev/7069822ab03c425676187eadca1d8e0d84ff3b5b/servo/components/style/values/specified/length.rs#789

But it is the right thing to do, and I'm considering adding another code
path to copy reset properties in bug 1841128 for first-line reparenting,
and not doing this would cause correctness issues.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b6ec67a78bf5
Copy container units bit when reusing reset properties. r=dshin

https://hg.mozilla.org/mozilla-central/rev/b6ec67a78bf5

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox117: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: