1841547 - Attempting to publish a calendar via FTP should show appropriate error message, also for other invalid protocols

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Francesco]

+++ This bug was initially created as a clone of Bug #1709448 +++

FTP support was removed in bug 1709448. When publishing a calendar to FTP using TB 102 the dialog simply does nothing, in the error console I see NS_ERROR_UNKNOWN_PROTOCOL.

In TB 115 there is nothing in the error console, or perhaps it fails earlier on

Uncaught TypeError: this._buttons is undefined
    getButton chrome://global/content/elements/dialog.js:190
    checkURLField chrome://calendar/content/publishDialog.js:48
    loadCalendarPublishDialog chrome://calendar/content/publishDialog.js:27
    publishEntireCalendar chrome://calendar/content/publish.js:89
    <anonymous> Choo
    _fireButtonEvent chrome://global/content/elements/dialog.js:515
    _doButtonCommand chrome://global/content/elements/dialog.js:494
    _handleButtonCommand chrome://global/content/elements/dialog.js:488
    publishEntireCalendar chrome://calendar/content/publish.js:65
    doCommand chrome://calendar/content/calendar-command-controller.js:370
    goDoCommand chrome://messenger/content/globalOverlay.js:99
    oncommand chrome://messenger/content/messenger.xhtml:1

Side issue: Does publishing work in 115 for a non-FTP calendar? Sorry, can't try.

Comment 1

[Francesco]

Correction: NS_ERROR_UNKNOWN_PROTOCOL still shows in 115 after the panel is closed.

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: Bug 1841547 - Don't allow trying to publish calendar to incorrect URLs. r=john.bieling

Make the publish button disabled if it's not an http url.

Comment 3

[Philipp Kewisch [:Fallen][☁️📆]]

Hey, just saw this. Can you allow webcal and webcals as well? These are basically http(s), but some people will assume it is necessary and we don't need to block it.

Comment 4

[Magnus Melin [:mkmelin]]

Good point, let's add that!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bbcdfae7ff3a
Don't allow trying to publish calendar to incorrect URLs. r=john.bieling

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 9359754 [details]
Bug 1841547 - Don't allow trying to publish calendar to incorrect URLs. r=john.bieling

[Approval Request Comment]
User impact if declined: non-informative UI
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): safe

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9359754 [details]
Bug 1841547 - Don't allow trying to publish calendar to incorrect URLs. r=john.bieling

[Triage Comment]
Approved for beta

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 120.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/2b4cc07dbb92

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9359754 [details]
Bug 1841547 - Don't allow trying to publish calendar to incorrect URLs. r=john.bieling

[Triage Comment]
Approved for esr115

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 115.4.2:
https://hg.mozilla.org/releases/comm-esr115/rev/b92e4b8c6f3d