1841553 - JsonSchemaValidator: Add "additionalProperties" to schema objects and rename "allowExtraProperties" to "allowAdditionalProperties"

Status: RESOLVED FIXED

(Toolkit :: General, task, P1)

Description

[Drew Willcoxon :adw]

The JSON schema standard supports an additionalProperties property inside individual schema objects. I need this for a feature I'm working on in bug 1841408. Our JsonSchemaValidator already has a global version of this called allowExtraProperties. I'd like to add support for additionalProperties and then rename allowExtraProperties to allowAdditionalProperties for consistency.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1841553 - JsonSchemaValidator: Support "additionalProperties" in schema objects and rename "allowExtraProperties" to "allowAdditionalProperties".

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/768efc56d694
JsonSchemaValidator: Support "additionalProperties" in schema objects and rename "allowExtraProperties" to "allowAdditionalProperties". r=mossop

Comment 3

[Drew Willcoxon :adw]

Comment on attachment 9342141 [details]
Bug 1841553 - JsonSchemaValidator: Support "additionalProperties" in schema objects and rename "allowExtraProperties" to "allowAdditionalProperties".

Beta/Release Uplift Approval Request

• User impact if declined: This bug is necessary for the Pocket suggestions feature we intend to ship as an experiment in 116.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just a small change to the JSON schema validator. No user-visible changes. Has tests.
• String changes made/needed:
• Is Android affected?: No

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/768efc56d694

Comment 5

[Dianna Smith [:diannaS]]

Comment on attachment 9342141 [details]
Bug 1841553 - JsonSchemaValidator: Support "additionalProperties" in schema objects and rename "allowExtraProperties" to "allowAdditionalProperties".

Approved for 116.0b2

Comment 6

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/fb4a75953d55