1841574 - checkbox in bookmark menu item lost end gravity

Status: RESOLVED FIXED

(Fenix :: Bookmarks, defect)

Description

[Mike a [:mavduevskiy]]

Attachment: Screenshot 2023-07-04 at 2.03.58 PM.png

The patch that fixed 1812825 bug failed to honor the previous gravity of the button. It was rightly constrained by the text element at the start and parent element at the end, but the element stopped "leaning" towards the end of the screen. The visibility of the change depends on the locale, for locales with longer words it isn't visible, but with shorter words or with wider screens the change becomes more apparent.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1841574 – changed menu item checkbox gravity from center horizontal to end (#2699)

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1812825

Comment 3

[Donal Meehan [:dmeehan]]

::mavduevskiy can this be reviewed and landed? Would it be safe to backport to 115 and 116?

Comment 4

[Joe M [:jmahon]]

:dmeehan Mike is on PTO this week, and it looks like Sarah has an outstanding question on this PR, so I don't think it can be (or needs to be) picked up for 115 or 116 at the moment, but we can consider uplifting once he's back & has finished up the PR next week.

Comment 5

[BMO Github Automation]

Authored by mike a
https://github.com/mozilla-mobile/firefox-android/commit/d900cfb022858279f763b11c922542698014d550
[main] Bug 1841574 – changed menu item checkbox gravity from center horizontal to end

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mavduevskiy, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox117 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Mira Lobontiu (Android QA)]

Verified on the latest Fenix Nightly 118.0a1 from 8/10 woth the following devices:

• Oppo Find X3 Lite (Android 11),
• Sony Xperia Z5 Premium (Android 7.1.1), and
• Google Pixel 6 (Android 14).

I've verified that the star icon and the "Add", or "Edit" options situated at the right side of the "Bookmarks" option from the thee-dot menu are "leaning" towards the end of the screen. The visibility of the change depends on the locale, for locales with longer words it isn't visible, but with shorter words or with wider screens the change becomes more apparent.