Windows native share pane's "Copy Link" item is slow and works only sporadically
Categories
(Core :: Widget: Win32, defect)
Tracking
()
People
(Reporter: david.balazic, Unassigned)
Details
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/115.0
Steps to reproduce:
- Right click a tab (not the visible one) to get the menu.
- select Share
- in the popup/dialog thing (why does it have a completely different L-A-F than the rest of Firefox?) click "Copy link"
Actual results:
- the popup disappears (it takes almost a second!)
- the clipboard is empty
Expected results:
- the popup disappears (immediately)
- the clipboard has the URL
Note: if the clipboard had some (text) content before the test, then after the clipboard is empty.
|
Reporter | |
Comment 1•2 years ago
|
||
This happens even in a freshly created profile.
|
|
Reporter | |
Comment 2•2 years ago
|
||
As the title says, every n-th time the link is copied to clipboard, but usually it just clears the clipboard.
|
||
Comment 3•2 years ago
|
||
The Bugbug bot thinks this bug should belong to the 'Firefox::Menus' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.
|
||
Comment 4•2 years ago
|
||
Hey there,
in the popup/dialog thing (why does it have a completely different L-A-F than the rest of Firefox?)
The look and feel is different because the share menu is supplied by the OS; all Firefox does is request that it be rendered. it's a totally different menu on different platforms.
As the title says, every n-th time the link is copied to clipboard, but usually it just clears the clipboard.
Have you observed this same bug when using the share menu on other applications on your machine?
|
||
Comment 5•2 years ago
|
||
I'm tempted to close this as INVALID and say that this is most likely a Windows issue, as both the menu and the behaviour when clicking "Copy link" are entirely controlled by Windows. We hand them a URL to do something with, and that's about where Firefox's role ends in this process.
David, do you have a second to supply the information jhirsch requested in comment 3?
|
|
Reporter | |
Comment 6•2 years ago
|
||
(In reply to Jared Hirsch [:jhirsch] (he/him) (Needinfo please) from comment #4)
Have you observed this same bug when using the share menu on other applications on your machine?
No as I know no other app that uses this feature. MS Edge for example has a share dialog that looks completely different.
|
||
Comment 7•2 years ago
|
||
(In reply to David Balažic from comment #6)
(In reply to Jared Hirsch [:jhirsch] (he/him) (Needinfo please) from comment #4)
Have you observed this same bug when using the share menu on other applications on your machine?
No as I know no other app that uses this feature. MS Edge for example has a share dialog that looks completely different.
The initial MS edge menu is different but has a "Windows share options" item that you can use to bring up the same dialog that Firefox shows. It would be useful to know if that has the same issue.
This is all the published native Windows API to do link sharing - but clearly other people at MS (the ones building Edge) also decided it isn't very good, given they have wrapped it with their own pane...
Kagami, I don't suppose you have other suggestions for debugging why this pane would work only intermittently and/or is so slow? (I can at least reproduce the slowness...)
|
||
Comment 8•2 years ago
|
||
(In reply to :Gijs (he/him) from comment #7)
Kagami, I don't suppose you have other suggestions for debugging why this pane would work only intermittently and/or is so slow? (I can at least reproduce the slowness...)
I can't reproduce it myself, it may make sense to check whether you get the right string in WindowsUIUtils::Share in the parent process. Perhaps something is passing an unreasonably long broken string? The part we are passing URL is here.
(In reply to David Balažic from comment #6)
(In reply to Jared Hirsch [:jhirsch] (he/him) (Needinfo please) from comment #4)
Have you observed this same bug when using the share menu on other applications on your machine?
No as I know no other app that uses this feature. MS Edge for example has a share dialog that looks completely different.
FWIW Chrome uses the same dialog, you can try here https://web-share.glitch.me/ . Maybe worth checking whether it's also slow on Chrome.
|
|
Reporter | |
Comment 9•2 years ago
|
||
(In reply to :Gijs (he/him) from comment #7)
The initial MS edge menu is different but has a "Windows share options" item that you can use to bring up the same dialog that Firefox shows. It would be useful to know if that has the same issue.
Yes, it behaves the same as in Firefox: makes the clipboard empty instead of containing the URL, mailto open the Mail app instead of Outlook
Did not notice the slowness.
not a firefox bug, apparently
|
|
||
Comment 10•2 years ago
|
||
(In reply to David Balažic from comment #9)
(In reply to :Gijs (he/him) from comment #7)
The initial MS edge menu is different but has a "Windows share options" item that you can use to bring up the same dialog that Firefox shows. It would be useful to know if that has the same issue.
Yes, it behaves the same as in Firefox: makes the clipboard empty instead of containing the URL, mailto open the Mail app instead of Outlook
Did not notice the slowness.not a firefox bug, apparently
No, but still frustrating for our users... :-(
Doing the same thing as Edge and building our own UI is expensive but perhaps we should be considering it here.
Kagami, has this been discussed at all on the spec level? Do we know what informs the lists of websites that Edge provides as share targets?
(to clarify, I can't reproduce the missing URL issue myself, though I do see some slowness in dismissing the dialog)
(In reply to David Balažic from comment #9)
Yes, it behaves the same as in Firefox: makes the clipboard empty instead of containing the URL, mailto open the Mail app instead of Outlook
Did not notice the slowness.not a firefox bug, apparently
I suspect a broken system in that case 🤔
(In reply to :Gijs (he/him) from comment #10)
No, but still frustrating for our users... :-(
Is it? Do we know how frequent the slowness is? We need to make sure first that this is not a Gecko issue or a rare broken OS issue.
Doing the same thing as Edge and building our own UI is expensive but perhaps we should be considering it here.
We do need our own UI anyway because not all OS have a native share dialog, notably Linux.
Kagami, has this been discussed at all on the spec level?
You mean a way to add an app to the share dialog? There is a spec for web apps: https://w3c.github.io/web-share-target/ but it's Blink only so far. (It doesn't seem to work on Windows though.)
Do we know what informs the lists of websites that Edge provides as share targets?
What Edge is doing is AFAIK completely arbitrary, it just shows whatever it wants to advertise. (It shows Facebook/Twitter/WhatsApp/Outlook/Gmail/LinkedIn while I don't have any of such apps installed on my machine.)
|
|
||
Comment 12•2 years ago
|
||
The severity field is not set for this bug.
:rkraesig, could you have a look please?
For more information, please visit BugBot documentation.
|
||
Comment 13•2 years ago
|
||
Closing as RESOLVED INVALID per reporter:
(In reply to David Balažic from comment #9)
not a firefox bug, apparently
Description
•