1841773 - The link displayed after extension migration appears gray instead of blue as in Figma

Status: NEW

(Firefox :: Migration, defect, P3)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: image.png

Found in

• 116.0b1

Affected versions

• 116.0b1
• 117.0a1 (2023-07-04)

Preconditions

• random extensions installed on Chrome
• browser.migrate.chrome.extensions.enabled:true

Tested platforms

• Affected platforms: Windows 10x64, macOS 12, Ubuntu 22.04
• Unaffected platforms: none

Steps to reproduce

1. Open the new migration window and import extensions.
2. Observe the Extensions link.

Expected result

• The Extensions link is blue per Figma

Actual result

• The Extensions link is grey.

Regression range

• Not a regression.

Additional notes

• Attached a screenshot.
• This happens for all three scenarios (full success, partial success, no matches).

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:atrif, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Tim Giles [:tgiles]]

To help Mozilla out with this bug, here's the steps:

1. Comment here on the bug that you want to volunteer to help.
   This will tell others that you're working on the next steps.
2. Download and build the Firefox source code
   • Here is a more detailed tutorial for getting set up to work on Firefox
   • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
3. Start working on this bug.
   • You'll need to fix the anchors in the extensions section so that they have the existing font-size from deemphasized-text but not the color changes from the @media not (prefers-contrast) query. We don't want to break .deemphasized-text for any other elements using it.
   • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #fx-desktop-dev channel on Element/Matrix most hours of most days.
4. Build your change with mach build and test your change by importing extensions from Chrome. Also check your changes for adherence to our style guidelines by using mach lint.
5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
   • How to Submit a Patch
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch, I'll push it to autoland.
   • If there are changes requested, please read the "To update a submitted patch" section to ensure you don't accidentally create a duplicate revision!
   • Your code will soon be shipping to Firefox users worldwide!

Comment 3

[Deepjyoti Deka]

Hi, I am looking into this bug and interested to work on it

Comment 4

[Nithin]

Hi Tim, I would like to work on this, can you let me know if I can submit a patch or is someone else working on this.
Also could you let me know if there are any test cases that needs to written.

Comment 5

[Nithin]

Attachment: Bug 1841773 - Use LinkText for link color in migration wizard in the extensions section. r?tgiles

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.