Closed Bug 1841786 Opened 5 months ago Closed 2 months ago

Add support for serialization of "generator" and "proxy"

Categories

(Remote Protocol :: WebDriver BiDi, task, P2)

Product:
Remote Protocol
Component:
WebDriver BiDi
Type:
task
Points:
3

Tracking

(firefox120 fixed)

Status:
RESOLVED FIXED
Milestone:
120 Branch
Tracking Flags:
Tracking Status
firefox120 --- fixed

People

(Reporter: whimboo, Assigned: Sasha)

References

(Blocks 1 open bug)

Details

(Whiteboard: [webdriver:m8][wptsync upstream][webdriver:relnote])

Attachments

(2 files)

Bug 1841786 - [bidi] Add support for serialization of "generator" and "proxy".
48 bytes, text/x-phabricator-request
Details | Review
Bug 1841786 - [wdspec] Add test case for async generator.
48 bytes, text/x-phabricator-request
Details | Review

With https://github.com/web-platform-tests/wpt/pull/40814 tests are added for generator, iterator, and proxy.

The serialization for all those types hasn't been implemented yet in Firefox. So once the downstream sync happened for this PR we probably should get those remaining types added.

The downstream sync will actually happen on bug 1841084.

Depends on: 1841084
Points: --- → 3
Priority: -- → P2
Whiteboard: [webdriver:backlog]

There was one more follow-up fix on bug 1844762 for the tests.

Depends on: 1844762

Note that the missing support for those types result in 36 tests failing for evaluate and callFunction.

Assignee: nobody → aborovova
Status: NEW → ASSIGNED
Whiteboard: [webdriver:backlog] → [webdriver:m8]
Summary: Add support for serialization of "generator", "iterator" and "proxy" → Add support for serialization of "generator" and "proxy"

Serialization of iterators is moved to a bug 1853953.

Attachment #9352176 - Attachment description: Bug 1841786 - [bidi] Add support for serialization of "generator", "iterator" and "proxy". → WIP: Bug 1841786 - [bidi] Add support for serialization of "generator" and "proxy".
Attachment #9352176 - Attachment description: WIP: Bug 1841786 - [bidi] Add support for serialization of "generator" and "proxy". → Bug 1841786 - [bidi] Add support for serialization of "generator" and "proxy".
Pushed by aborovova@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/787457d5c9a7
[bidi] Add support for serialization of "generator" and "proxy". r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/aa2c62bd9e6b
[wdspec] Add test case for async generator. r=webdriver-reviewers,jdescottes
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/42186 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m8] → [webdriver:m8], [wptsync upstream]

https://hg.mozilla.org/mozilla-central/rev/787457d5c9a7
https://hg.mozilla.org/mozilla-central/rev/aa2c62bd9e6b

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox120: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch
Upstream PR merged by moz-wptsync-bot
Whiteboard: [webdriver:m8], [wptsync upstream] → [webdriver:m8][wptsync upstream][webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.