1841845 - Remove Services.jsm consumers in comm-central/suite

Status: RESOLVED FIXED

(SeaMonkey :: General, task)

Description

[Tooru Fujisawa [:arai]]

Services.jsm is going to be removed shortly.

comm-central/suite contains references, and those needs to be removed.

https://searchfox.org/comm-central/search?q=%2FServices.jsm&path=suite%2F&case=false&regexp=false

In most case, simply removing the statement should solve, given Services global variable is available in all privileged global from 104 (bug 1667455).

Comment 1

[Edmund Wong (:ewong)]

Attachment: wip1.patch

First patch in 5 (?) years... requesting feedback on whether my approach is
currently on track.

Comment 2

[Edmund Wong (:ewong)]

Attachment: wip1.patch

WIP patch #2 for review.

Comment 3

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9342667 [details] [diff] [review]
wip1.patch

ewong looks like the patch was done against 2.53 not comm-central. 2.53 is not affected and in the current state does not apply to central.

Comment 4

[Edmund Wong (:ewong)]

Attachment: bug_1841845_modules.diff

It helps that I'm using the right branch. Previous patch was on 2.53.

This is for suite/modules.

Comment 5

[Edmund Wong (:ewong)]

Attachment: bug_1841845_mailnews.diff

suite/mailnews part.

Comment 6

[Edmund Wong (:ewong)]

Attachment: bug_1841845_exteditor.diff

suite/extentions + suite/editor part

Comment 7

[Edmund Wong (:ewong)]

Attachment: bug_1841845_cz.diff

suite/chatzilla part

Comment 8

[Edmund Wong (:ewong)]

Attachment: bug_1841845_components.diff

suite/components part

Comment 9

[Edmund Wong (:ewong)]

Attachment: bug_1841845_browser.diff

suite/browser part

Comment 10

[Edmund Wong (:ewong)]

Attachment: bug_1841845_base.diff

suite/base part

Comment 11

[Gregory Pappas [:gregp]]

I'm pretty sure patches submitted via bugzilla are no longer accepted. Thunderbird is using Phabricator now
https://developer.thunderbird.net/thunderbird-development/fixing-a-bug#submitting-a-patch

bleh, I didn't even notice this bug is about suite. Nevermind then

Comment 12

[Edmund Wong (:ewong)]

Attachment: bug_1841845_base.diff

updated patch with description + Username info.

Comment 13

[Edmund Wong (:ewong)]

Attachment: bug_1841845_browser.diff

[suite/browser]
updated patch with description + Username info.

Comment 14

[Edmund Wong (:ewong)]

Attachment: bug_1841845_components.diff

suite/components
updated patch with description + Username info.

Comment 15

[Edmund Wong (:ewong)]

Attachment: bug_1841845_cz.diff

chatzilla
updated patch with description + Username info.

Comment 16

[Edmund Wong (:ewong)]

Attachment: bug_1841845_exteditor.diff

editor + extensions
updated patch with description + Username info.

Comment 17

[Edmund Wong (:ewong)]

Attachment: bug_1841845_mailnews.diff

suite/mailnews
updated patch with description + Username info.

Comment 18

[Edmund Wong (:ewong)]

Attachment: bug_1841845_modules.diff

suite/modules
updated patch with description + Username info.

Comment 19

[Tooru Fujisawa [:arai]]

Comment on attachment 9343671 [details] [diff] [review]
bug_1841845_mailnews.diff

Review of attachment 9343671 [details] [diff] [review]:
-----------------------------------------------------------------

::: suite/mailnews/content/mailWidgets.xml
@@ -1076,4 @@
>          var { MailServices } = ChromeUtils.import(
>            "resource:///modules/MailServices.jsm"
>          );
> -        ChromeUtils.import("resource://gre/modules/Services.jsm", this);

`ChromeUtils.import` consumers in this file uses the 2nd parameter to import the module into `this` object, and uses `this.Services` style to access it.

https://searchfox.org/comm-central/rev/6fb5895249a6f1abef7471b55198813abb3b34ff/suite/mailnews/content/mailWidgets.xml#994
```
this.Services.strings.createBundle(
```

Those consumers also need to be updated to use `Services` global variable instead.

Comment 20

[Edmund Wong (:ewong)]

Attachment: bug_1841845_mailnews.diff

Thanks to @arai for the nit. Updated the mailnews patch.

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9f2df07917b5
Remove Services.jsm consumers in c-c/suite - base. r=IanN
https://hg.mozilla.org/comm-central/rev/bdcdb34c8dee
Remove Services.jsm consumers in c-c/suite - browser. r=IanN
https://hg.mozilla.org/comm-central/rev/6755b0e5c044
Remove Services.jsm consumers in c-c/suite - components. r=IanN
https://hg.mozilla.org/comm-central/rev/db4628285a31
Remove Services.jsm consumers in c-c/suite - chatzilla. r=IanN
https://hg.mozilla.org/comm-central/rev/a994a09bd38c
Remove Services.jsm consumers in c-c/suite - editor/extensions. r=IanN
https://hg.mozilla.org/comm-central/rev/899e313586fb
Remove Services.jsm consumers in c-c/suite - modules. r=IanN
https://hg.mozilla.org/comm-central/rev/82cc162e6567
Remove Services.jsm consumers in c-c/suite - mailnews. r=IanN

Comment 22

[Frank-Rainer Grahl (:frg)]

Sorry took me awhile to check this in. Was a bit busy with the 2.53.17 release and personal stuff.