1841865 - [wpt-sync] Sync PR 40890 - Store the COOP restrict crossOriginIsolated bit in WebLocalFrameImpl.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 40890 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/40890
Details from upstream follow.

Jonathan Hao <[e-mail]> wrote:

Store the COOP restrict crossOriginIsolated bit in WebLocalFrameImpl.

In https://crrev.com/c/4479858, the browser computes a boolean that
determines whether COOP origin forbids an iframe to be
crossOriginIsolatedwe, and send the boolean on CommitNavigation in order
to restrict crossOriginIsolated on an iframe and its top level frame has
a mismatched COOP origin. It causes breakage such as b/288962508 (Google
only) because SharedArrayBuffer's constructor sometimes needs to be
enabled earlier than CommitNavigation, which causes SharedArrayBuffer to
be undefined even though crossOriginIsolated is true.

Since we also computes the boolean for the main frame when then window
is created, the solution in this CL is as follows:

1. Each WebLocalFrameImpl stores a boolean that decides whether COOP
   origin forbids this frame to be crossOriginIsolated.
2. Whenever a child frame is created, in CreateChildFrame, we pass the
   boolean down to the child frame via InitializeCoreFrameInternal. When
   the parent frame is the main frame, we only pass true when it's an
   initial empty document.

As before, InitializeCoreFrameInternal will eventually store the boolean
in LocalFrame and we can read it in LocalDOMWindow.

Bug: 1385827
Change-Id: I1330c30ad056d9f94ee7b7747eac68ae47b56acc
Reviewed-on: https://chromium-review.googlesource.com/4666003
WPT-Export-Revision: caf9100c1653515623042a2f4733e1dcb1a2de73

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=cfbc436eeecd01b052b2244524d5fdeecc458e8d

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

OK : 1
FAIL: 2

Chrome

OK : 1
FAIL: 2

Safari

OK : 1
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/cross-origin-opener-policy/tentative/restrict-properties/iframe-popup-about-blank.https.window.html [wpt.fyi]
  • Cross-origin iframe: FAIL (Chrome: FAIL, Safari: FAIL)
  • Same-origin iframe: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3944cc0b9c49
[wpt PR 40890] - Store the COOP restrict crossOriginIsolated bit in policy container., a=testonly

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/3944cc0b9c49