1841919 - error: variable does not need to be mutable

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Mike Hommey [:glandium]]

Building with upcoming rustc 1.71 fails with (with warnings as errors):

[task 2023-07-06T00:54:15.842Z] 00:54:15     INFO -  error: variable does not need to be mutable
[task 2023-07-06T00:54:15.842Z] 00:54:15     INFO -    --> gfx/wr/webrender_api/src/display_item_cache.rs:61:13
[task 2023-07-06T00:54:15.842Z] 00:54:15     INFO -     |
[task 2023-07-06T00:54:15.842Z] 00:54:15     INFO -  61 |         let mut entry = &mut self.entries[key as usize];
[task 2023-07-06T00:54:15.842Z] 00:54:15     INFO -     |             ----^^^^^
[task 2023-07-06T00:54:15.842Z] 00:54:15     INFO -     |             |
[task 2023-07-06T00:54:15.842Z] 00:54:15     INFO -     |             help: remove this `mut`
[task 2023-07-06T00:54:15.842Z] 00:54:15     INFO -     |
[task 2023-07-06T00:54:15.842Z] 00:54:15     INFO -     = note: `-D unused-mut` implied by `-D warnings`
[task 2023-07-06T00:54:15.843Z] 00:54:15     INFO -  error: variable does not need to be mutable
[task 2023-07-06T00:54:15.843Z] 00:54:15     INFO -    --> gfx/wr/webrender_api/src/display_item_cache.rs:67:13
[task 2023-07-06T00:54:15.843Z] 00:54:15     INFO -     |
[task 2023-07-06T00:54:15.843Z] 00:54:15     INFO -  67 |         let mut entry = &mut self.entries[key as usize];
[task 2023-07-06T00:54:15.843Z] 00:54:15     INFO -     |             ----^^^^^
[task 2023-07-06T00:54:15.843Z] 00:54:15     INFO -     |             |
[task 2023-07-06T00:54:15.843Z] 00:54:15     INFO -     |             help: remove this `mut`
[task 2023-07-06T00:54:15.843Z] 00:54:15     INFO -  error: could not compile `webrender_api` (lib) due to 2 previous errors

Comment 1

[Mike Hommey [:glandium]]

More:

0:07.40 error: variable does not need to be mutable
 0:07.40     --> gfx/wr/webrender/src/compositor/sw_compositor.rs:1029:21
 0:07.40      |
 0:07.40 1029 |                 let mut tile = &mut surface.tiles[0];
 0:07.40      |                     ----^^^^
 0:07.40      |                     |
 0:07.40      |                     help: remove this `mut`
 0:07.40      |
 0:07.40      = note: `-D unused-mut` implied by `-D warnings`
 0:07.67 error: variable does not need to be mutable
 0:07.67     --> gfx/wr/webrender/src/picture.rs:2891:13
 0:07.67      |
 0:07.67 2891 |         let mut surface = &mut surfaces[prim_surface_index.0];
 0:07.67      |             ----^^^^^^^
 0:07.67      |             |
 0:07.67      |             help: remove this `mut`

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1841919 - Fix "variable does not need to be mutable" warnings in webrender.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4d6ad7c5e44
Fix "variable does not need to be mutable" warnings in webrender. r=gfx-reviewers,lsalzman

Comment 4

[Mike Hommey [:glandium]]

More:

[task 2023-07-06T03:18:24.792Z] error: variable does not need to be mutable
[task 2023-07-06T03:18:24.792Z]    --> wrench/src/reftest.rs:517:25
[task 2023-07-06T03:18:24.792Z]     |
[task 2023-07-06T03:18:24.792Z] 517 |                     let mut fuzzy = &mut fuzziness[0];
[task 2023-07-06T03:18:24.792Z]     |                         ----^^^^^
[task 2023-07-06T03:18:24.792Z]     |                         |
[task 2023-07-06T03:18:24.792Z]     |                         help: remove this `mut`
[task 2023-07-06T03:18:24.792Z]     |
[task 2023-07-06T03:18:24.792Z]     = note: `-D unused-mut` implied by `-D warnings`
[task 2023-07-06T03:18:24.792Z] 
[task 2023-07-06T03:18:25.020Z] error: could not compile `wrench` (lib) due to previous error
[task 2023-07-06T03:18:25.020Z] 

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1841919 - Fix "variable does not need to be mutable" warning in wrench.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea780120e917
Fix "variable does not need to be mutable" warning in wrench. r=gfx-reviewers,jrmuizel

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c4d6ad7c5e44
https://hg.mozilla.org/mozilla-central/rev/ea780120e917