1841921 - error: variable does not need to be mutable

Status: RESOLVED FIXED

(Core :: Graphics: Color Management, defect)

Description

[Mike Hommey [:glandium]]

Building with upcoming rustc 1.71 fails with (with warnings as errors):

[task 2023-07-06T01:22:24.532Z] 01:22:24     INFO -      |
[task 2023-07-06T01:22:24.532Z] 01:22:24     INFO -  302 | fn read_class_signature(mut profile: &mut Profile, mem: &mut MemSource) {
[task 2023-07-06T01:22:24.532Z] 01:22:24     INFO -      |                         ----^^^^^^^
[task 2023-07-06T01:22:24.532Z] 01:22:24     INFO -      |                         |
[task 2023-07-06T01:22:24.532Z] 01:22:24     INFO -      |                         help: remove this `mut`
[task 2023-07-06T01:22:24.532Z] 01:22:24     INFO -  error: variable does not need to be mutable
[task 2023-07-06T01:22:24.533Z] 01:22:24     INFO -     --> gfx/qcms/src/iccread.rs:314:21
[task 2023-07-06T01:22:24.533Z] 01:22:24     INFO -      |
[task 2023-07-06T01:22:24.533Z] 01:22:24     INFO -  314 | fn read_color_space(mut profile: &mut Profile, mem: &mut MemSource) {
[task 2023-07-06T01:22:24.533Z] 01:22:24     INFO -      |                     ----^^^^^^^
[task 2023-07-06T01:22:24.533Z] 01:22:24     INFO -      |                     |
[task 2023-07-06T01:22:24.533Z] 01:22:24     INFO -      |                     help: remove this `mut`
[task 2023-07-06T01:22:24.533Z] 01:22:24     INFO -  error: variable does not need to be mutable
[task 2023-07-06T01:22:24.533Z] 01:22:24     INFO -     --> gfx/qcms/src/iccread.rs:325:13
[task 2023-07-06T01:22:24.533Z] 01:22:24     INFO -      |
[task 2023-07-06T01:22:24.533Z] 01:22:24     INFO -  325 | fn read_pcs(mut profile: &mut Profile, mem: &mut MemSource) {
[task 2023-07-06T01:22:24.533Z] 01:22:24     INFO -      |             ----^^^^^^^
[task 2023-07-06T01:22:24.534Z] 01:22:24     INFO -      |             |
[task 2023-07-06T01:22:24.534Z] 01:22:24     INFO -      |             help: remove this `mut`
[task 2023-07-06T01:22:24.534Z] 01:22:24     INFO -  error: variable does not need to be mutable
[task 2023-07-06T01:22:24.534Z] 01:22:24     INFO -     --> gfx/qcms/src/iccread.rs:866:26
[task 2023-07-06T01:22:24.534Z] 01:22:24     INFO -      |
[task 2023-07-06T01:22:24.534Z] 01:22:24     INFO -  866 | fn read_rendering_intent(mut profile: &mut Profile, src: &mut MemSource) {
[task 2023-07-06T01:22:24.534Z] 01:22:24     INFO -      |                          ----^^^^^^^
[task 2023-07-06T01:22:24.534Z] 01:22:24     INFO -      |                          |
[task 2023-07-06T01:22:24.537Z] 01:22:24     INFO -      |                          help: remove this `mut`
[task 2023-07-06T01:22:24.537Z] 01:22:24     INFO -  error: variable does not need to be mutable
[task 2023-07-06T01:22:24.537Z] 01:22:24     INFO -      --> gfx/qcms/src/iccread.rs:1605:13
[task 2023-07-06T01:22:24.537Z] 01:22:24     INFO -       |
[task 2023-07-06T01:22:24.537Z] 01:22:24     INFO -  1605 |         let mut src: &mut MemSource = &mut source;
[task 2023-07-06T01:22:24.537Z] 01:22:24     INFO -       |             ----^^^
[task 2023-07-06T01:22:24.537Z] 01:22:24     INFO -       |             |
[task 2023-07-06T01:22:24.538Z] 01:22:24     INFO -       |             help: remove this `mut`
[task 2023-07-06T01:22:24.538Z] 01:22:24     INFO -  error: variable does not need to be mutable
[task 2023-07-06T01:22:24.538Z] 01:22:24     INFO -     --> gfx/qcms/src/transform.rs:359:5
[task 2023-07-06T01:22:24.538Z] 01:22:24     INFO -      |
[task 2023-07-06T01:22:24.538Z] 01:22:24     INFO -  359 |     mut profile: &mut Profile,
[task 2023-07-06T01:22:24.538Z] 01:22:24     INFO -      |     ----^^^^^^^
[task 2023-07-06T01:22:24.538Z] 01:22:24     INFO -      |     |
[task 2023-07-06T01:22:24.538Z] 01:22:24     INFO -      |     help: remove this `mut`
[task 2023-07-06T01:22:24.538Z] 01:22:24     INFO -  error: variable does not need to be mutable
[task 2023-07-06T01:22:24.538Z] 01:22:24     INFO -      --> gfx/qcms/src/transform.rs:1156:58
[task 2023-07-06T01:22:24.539Z] 01:22:24     INFO -       |
[task 2023-07-06T01:22:24.539Z] 01:22:24     INFO -  1156 | pub extern "C" fn qcms_profile_precache_output_transform(mut profile: &mut Profile) {
[task 2023-07-06T01:22:24.539Z] 01:22:24     INFO -       |                                                          ----^^^^^^^
[task 2023-07-06T01:22:24.539Z] 01:22:24     INFO -       |                                                          |
[task 2023-07-06T01:22:24.539Z] 01:22:24     INFO -       |                                                          help: remove this `mut`
[task 2023-07-06T01:22:24.540Z] 01:22:24     INFO -  error: could not compile `qcms` (lib) due to 8 previous errors

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1841921 - Fix "variable does not need to be mutable" warnings in qcms.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce5753685c87
Fix "variable does not need to be mutable" warnings in qcms. r=gfx-reviewers,lsalzman

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ce5753685c87